Re: Fwd: Re: randconfig build error with next-20141001, in drivers/i2c/algos/i2c-algo-bit.c

[Stephane Grosjean <s.grosjean@peak-system.com>]

Hi Oliver,

Le 06/10/2014 10:09, Oliver Hartkopp a écrit :
> Hi Stephane,
>
> I'm back home.
>
> But I wondered if this problem really is a problem with our current Kconfig.

Well, you're right when you say that the PEAK_PCIEC option won't be 
visible if CONFIG_I2C is not selected.
AFAIR, my first  version of Kconfig used the "depends on" keyword rather 
then the "select" one.
Anyway, if we had to change this Kconfig, we could take the opportunity 
to upgrade the help text, by adding the info of the support of the new 
PCAN-ExpressCard 34.

Regards,

Stéphane

>
> Let's first wait for the answer from the complaining guys.
>
> Best regards,
> Oliver
>
> On 10/06/2014 09:52 AM, Stephane Grosjean wrote:
>> Hi Oliver,
>>
>> Sorry I was not at the office last week too ... :-/
>>
>> So, I send the patch to Marc asap ...
>>
>> Regards,
>>
>> Stéphane
>>
>>
>>
>> Le 02/10/2014 17:18, Oliver Hartkopp a écrit :
>>> Hello Stephane,
>>>
>>> can you please send a short patch for that to Marc/linux-can ?
>>> I'm currently out of office.
>>>
>>> Tnx,
>>> Oliver
>>>
>>>
>>> -------- Forwarded Message --------
>>> Subject: Re: randconfig build error with next-20141001, in
>>> drivers/i2c/algos/i2c-algo-bit.c
>>> Date: Wed, 01 Oct 2014 16:26:11 -0700
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>> To: Jim Davis <jim.epost@gmail.com>, Stephen Rothwell <sfr@canb.auug.org.au>,
>>> linux-next <linux-next@vger.kernel.org>, linux-kernel
>>> <linux-kernel@vger.kernel.org>, wsa@the-dreams.de, khali@linux-fr.org, Paul
>>> Gortmaker <paul.gortmaker@windriver.com>, linux-i2c@vger.kernel.org,
>>> netdev@vger.kernel.org <netdev@vger.kernel.org>, linux-can@vger.kernel.org,
>>> linux-media <linux-media@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>
>>>
>>> On 10/01/14 14:37, Jim Davis wrote:
>>>> Building with the attached random configuration file,
>>> Also:
>>> warning: (CAN_PEAK_PCIEC && SFC && IGB && VIDEO_TW68 && DRM && FB_DDC &&
>>> FB_VIA) selects I2C_ALGOBIT which has unmet direct dependencies (I2C)
>>>
>>>> drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_bus’:
>>>> drivers/i2c/algos/i2c-algo-bit.c:658:33: error: ‘i2c_add_adapter’
>>>> undeclared (first use in this function)
>>>>     return __i2c_bit_add_bus(adap, i2c_add_adapter);
>>>>                                    ^
>>>> drivers/i2c/algos/i2c-algo-bit.c:658:33: note: each undeclared
>>>> identifier is reported only once for each function it appears in
>>>> drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_numbered_bus’:
>>>> drivers/i2c/algos/i2c-algo-bit.c:664:33: error:
>>>> ‘i2c_add_numbered_adapter’ undeclared (first use in this function)
>>>>     return __i2c_bit_add_bus(adap, i2c_add_numbered_adapter);
>>>>                                    ^
>>>>     CC      net/openvswitch/actions.o
>>>> drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_bus’:
>>>> drivers/i2c/algos/i2c-algo-bit.c:659:1: warning: control reaches end of
>>>> non-void
>>>>    function [-Wreturn-type]
>>>>    }
>>>>    ^
>>>> drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_numbered_bus’:
>>>> drivers/i2c/algos/i2c-algo-bit.c:665:1: warning: control reaches end of
>>>> non-void
>>>>    function [-Wreturn-type]
>>>>    }
>>>>    ^
>>>> make[3]: *** [drivers/i2c/algos/i2c-algo-bit.o] Error 1
>>> In drivers/media/pci/tw68/Kconfig, VIDEO_TW68 should depend on I2C in order
>>> to make it safe to select I2C_ALGOBIT.
>>>
>>> In drivers/net/can/sja1000/Kconfig, CAN_PEAK_PCIEC should depend on I2C
>>> instead of selecting I2C (and change the help text).
>>>
>>>
>> -- 
>> PEAK-System Technik GmbH
>> Sitz der Gesellschaft Darmstadt
>> Handelsregister Darmstadt HRB 9183 Geschaeftsfuehrung: Alexander Gach, Uwe
>> Wilhelm
>> -- 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt
Handelsregister Darmstadt HRB 9183 
Geschaeftsfuehrung: Alexander Gach, Uwe Wilhelm
--