Re: cpufreq: Unable to set cpufreq to maximum

[Stefan Wahren <stefan.wahren@i2se.com>]

Am 06.10.2014 um 10:50 schrieb Viresh Kumar:
> On 6 October 2014 12:11, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> Ignoring errors isn't a solution. I have another idea. I've looked a
>> little bit at the code in the cpufreq-(cpu0/dt). Usually the frequencies
>> are rounded down, but in cpu0_set_target() with
>> dev_pm_opp_find_freq_ceil(cpu_dev, &freq_Hz) they are rounded up. From
>> my point of view that's wrong.
> @Shawn ??
>
>> I fixed the problem by decreasing frequency in DT and replacing
>> dev_pm_opp_find_freq_ceil() with dev_pm_opp_find_freq_floor() in
>> cpufreq-cpu0.c . Unfortunatelly this will break all other DTS files with
>> roundings in OPPs.
> I am still not sure how this fixed your problem..

Sorry, about the confusion. The main problem about setting cpufreq to
maximum has been fixed by DT settings. Above i talked about an idea to
fix the confusing warning after fixing the main problem:

root@duckbill:~# modprobe cpufreq-cpu0
[   48.573808] cpufreq: __cpufreq_add_dev: CPU0: Running at unlisted
freq: 454736 KHz
[   48.604871] cpufreq: __cpufreq_add_dev: CPU0: Unlisted initial
frequency changed to: 454737 KHz

But the best solution would be a more intelligent function like
dev_pm_opp_find_freq_nearest() which find the OPP with the smallest
frequency distance. So nobody of the DTS users has to care about
frequency rounding.

Currently i'm trying to adapt the DTS file to the driver and that's not
the intention of devicetree.

Stefan