From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?SmFudXN6IFXFvHlja2k=?= Subject: Re: [PATCH] serial: mxs-auart: add sysrq support Date: Mon, 06 Oct 2014 13:34:25 +0200 Message-ID: <54327E41.9070607@elproma.com.pl> References: <20140929014129.GA8687@kroah.com> <1411999905-27044-1-git-send-email-j.uzycki@elproma.com.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from v032797.home.net.pl ([89.161.177.31]:57205 "HELO v032797.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751488AbaJFLe2 (ORCPT ); Mon, 6 Oct 2014 07:34:28 -0400 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Fabio Estevam Cc: Greg Kroah-Hartman , Russell King - ARM Linux , Jiri Slaby , Richard Genoud , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Hi, W dniu 2014-10-04 18:19, Fabio Estevam pisze: > Janusz, > > On Mon, Sep 29, 2014 at 11:11 AM, Janusz Uzycki wrote: >>> So I'm deleting all of these now, please resend the latest >>> versions you have, with properly versioning >>> and order information. >> Sure. If you don't want to comment dirty patches >> I will not send you them. >> I can send you only the final version, commented before. >> >> On the moment this patch is ready to apply. >> >> [PATCH RESEND] serial: mxs-auart: add sysrq support >> The patch is resent to apply. > What Greg is asking you to do is to provide a proper version > annotation in your patches. > > For example: [PATCH v2] serial: mxs-auart: add ... > > Then if you need to submit it again you should do: > > [PATCH v3] serial: mxs-auart: add ... I will resend the rest of patches (as v4) this week. This simple patch is independent from the previous patchset so I decided to resubmit it alone ([PATCH RESEND] header used) to apply. I rather shouldn't resend the patch again I guess. I sent the same initial version of the patch twice after Greg's email so I did mess enough I think. > Also, always explain below the --- line what changed from one version to another I thought composing cover letter is the only solution for resent patch or series. As I understood this way is appropriate for single patch only (not patch set). "Below" - it means between the line and diffstat? Should I add new/second '---' line before diffstat? best regards Janusz From mboxrd@z Thu Jan 1 00:00:00 1970 From: j.uzycki@elproma.com.pl (=?UTF-8?B?SmFudXN6IFXFvHlja2k=?=) Date: Mon, 06 Oct 2014 13:34:25 +0200 Subject: [PATCH] serial: mxs-auart: add sysrq support In-Reply-To: References: <20140929014129.GA8687@kroah.com> <1411999905-27044-1-git-send-email-j.uzycki@elproma.com.pl> Message-ID: <54327E41.9070607@elproma.com.pl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, W dniu 2014-10-04 18:19, Fabio Estevam pisze: > Janusz, > > On Mon, Sep 29, 2014 at 11:11 AM, Janusz Uzycki wrote: >>> So I'm deleting all of these now, please resend the latest >>> versions you have, with properly versioning >>> and order information. >> Sure. If you don't want to comment dirty patches >> I will not send you them. >> I can send you only the final version, commented before. >> >> On the moment this patch is ready to apply. >> >> [PATCH RESEND] serial: mxs-auart: add sysrq support >> The patch is resent to apply. > What Greg is asking you to do is to provide a proper version > annotation in your patches. > > For example: [PATCH v2] serial: mxs-auart: add ... > > Then if you need to submit it again you should do: > > [PATCH v3] serial: mxs-auart: add ... I will resend the rest of patches (as v4) this week. This simple patch is independent from the previous patchset so I decided to resubmit it alone ([PATCH RESEND] header used) to apply. I rather shouldn't resend the patch again I guess. I sent the same initial version of the patch twice after Greg's email so I did mess enough I think. > Also, always explain below the --- line what changed from one version to another I thought composing cover letter is the only solution for resent patch or series. As I understood this way is appropriate for single patch only (not patch set). "Below" - it means between the line and diffstat? Should I add new/second '---' line before diffstat? best regards Janusz