All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] powerpc/mpc83xx: Zero boot_flags arg for calling board_init_f()
Date: Mon, 6 Oct 2014 13:19:21 -0700	[thread overview]
Message-ID: <5432F949.9060908@freescale.com> (raw)
In-Reply-To: <1412329524-31265-1-git-send-email-valentin.longchamp@keymile.com>

On 10/03/2014 02:45 AM, Valentin Longchamp wrote:
> The argument boot_flags of board_init_f() is not used at all in the
> powerpc specific board.c init sequence. Now with the generic init
> sequence, this boot_flags arg is used by board_init_f().
> 
> This patch sets the r3 register that is used to pass the boot_flags
> argument from the start.S board_init_f() call to 0 prior to the function
> call to avoid unknown content to end up in gd->flags.
> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> ---
> 
>  arch/powerpc/cpu/mpc83xx/start.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
> index 36724e5..8abb3f1 100644
> --- a/arch/powerpc/cpu/mpc83xx/start.S
> +++ b/arch/powerpc/cpu/mpc83xx/start.S
> @@ -283,6 +283,7 @@ in_flash:
>  	bl	cpu_init_f
>  
>  	/* run 1st part of board init code (in Flash)*/
> +	li	r3, 0		/* clear boot_flag for calling board_init_f */
>  	bl	board_init_f
>  
>  	/* NOTREACHED - board_init_f() does not return */
> 

Kim,

This is for 83xx. I think the patch is OK. I can take it in along with other
patches when the merge window opens if you are OK.

York

  parent reply	other threads:[~2014-10-06 20:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03  9:45 [U-Boot] [PATCH 1/2] powerpc/mpc83xx: Zero boot_flags arg for calling board_init_f() Valentin Longchamp
2014-10-03  9:45 ` [U-Boot] [PATCH 2/2] keymile/powerpc: move to the architecture-generic board system Valentin Longchamp
2014-11-14 21:29   ` York Sun
2014-10-06 20:19 ` York Sun [this message]
2014-11-14 21:29 ` [U-Boot] [PATCH 1/2] powerpc/mpc83xx: Zero boot_flags arg for calling board_init_f() York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5432F949.9060908@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.