From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, minyard@acm.org, qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting
Date: Mon, 06 Oct 2014 22:36:24 +0200 [thread overview]
Message-ID: <5432FD48.6020002@redhat.com> (raw)
In-Reply-To: <5432E14A.8030105@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 06/10/2014 20:36, Eric Blake ha scritto:
>>> - qemu_chr_socket_restart_timer(chr); +
>>> check_report_connect_error(chr, "Unable to connect to");
> Works in English, but if there is ever translation of the message
> printed in check_report_connect_error, you are probably doing
> translators a disservice by splitting a sentence into two parts
> separated by a number of lines of code. (Spoken by one who has
> never contributed a translation, so take with a grain of salt)
>
I agree, I think it's simpler to unify the two messages.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJUMv1IAAoJEBRUblpOawnXtFoH/1QIYr/yZXZQhw7zqDxiyhgH
Gto3UiDjd/eLNC/iFwdY3J2pnuHIu8yVmBAO68cALdK6KotZ6X/TGVpsGUmPeoPk
rPtkbxAvBvxdPImCUi798YSXbkOsVA/5+pMOOxNLeMwzA2ClFDFBqzgqgBbL/PwU
O25XgCNucwFpk6An5yTOblHbS5Ji6oSnfJfHkXwuZlzjE7ql2nbr0Gr9lEulgHk3
3+hDoyesCD55V0r1qO/CwGJsuyJ1PXJGxV65ML1ja6F+yiMjlCgaTmzLAtcdWu4A
oD6wR5auS9ZTWogS/JBxCx9oFnZVs19LgnSPSvQVHb3TaQJcVSTZuQjkb3/m8bU=
=ctwR
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-10-06 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 17:59 [Qemu-devel] [PATCH 0/2] qemu-char: Clean up socket reporting minyard
2014-10-06 17:59 ` [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting minyard
2014-10-06 18:36 ` Eric Blake
2014-10-06 19:52 ` Corey Minyard
2014-10-06 20:36 ` Paolo Bonzini [this message]
2014-10-08 6:56 ` Markus Armbruster
2014-10-06 17:59 ` [Qemu-devel] [PATCH 2/2] qemu-sockets: Add error to non-blocking connect handler minyard
2014-10-07 22:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5432FD48.6020002@redhat.com \
--to=pbonzini@redhat.com \
--cc=cminyard@mvista.com \
--cc=eblake@redhat.com \
--cc=minyard@acm.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.