From: Paolo Abeni <pabeni@redhat.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Marcin Wojtas <mw@semihalf.com>,
Russell King <linux@armlinux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: mvpp2: Defer probe if MAC address source is not yet ready
Date: Thu, 09 Mar 2023 11:12:18 +0100 [thread overview]
Message-ID: <5432f8f2da54d0ffc4e4e28fb88ac14f5bb682de.camel@redhat.com> (raw)
In-Reply-To: <20230307192927.512757-1-miquel.raynal@bootlin.com>
On Tue, 2023-03-07 at 20:29 +0100, Miquel Raynal wrote:
> NVMEM layouts are no longer registered early, and thus may not yet be
> available when Ethernet drivers (or any other consumer) probe, leading
> to possible probe deferrals errors. Forward the error code if this
> happens. All other errors being discarded, the driver will eventually
> use a random MAC address if no other source was considered valid (no
> functional change on this regard).
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
The patch LGTM, but if feels like a fix more than a new feature re-
factor. Any special reason to target the net-next tree?
Thanks!
Paolo
next prev parent reply other threads:[~2023-03-09 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 19:29 [PATCH net-next] net: mvpp2: Defer probe if MAC address source is not yet ready Miquel Raynal
2023-03-08 0:48 ` Marcin Wojtas
2023-03-09 10:12 ` Paolo Abeni [this message]
2023-03-09 10:29 ` Miquel Raynal
2023-03-11 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5432f8f2da54d0ffc4e4e28fb88ac14f5bb682de.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.