From: Martin Townsend <martin.townsend@xsilon.com>
To: linux-bluetooth@vger.kernel.org
Subject: Question on recv_pkt
Date: Tue, 07 Oct 2014 09:18:24 +0100 [thread overview]
Message-ID: <5433A1D0.4040803@xsilon.com> (raw)
Hi,
I'm trying to work out why the skb is cloned in recv_pkt in net/bluetooth/6lowpan.c when performing IPHC [0]. I would like to call process_data with an unshared skb as my proposal for the next patch is to use pskb_expand_head[1] in the decompression routine to save copying but this requires an skb with users == 1 otherwise it will call BUG().
In light of the locking problem Jukka was seeing with my previous patch I'm wondering if me removing this skb_clone was the cause so I want to make sure I know what it's there for before sending the patch. Any help is appreciated.
- Martin.
[0]http://lxr.free-electrons.com/source/net/bluetooth/6lowpan.c#L258
[1]http://lxr.free-electrons.com/source/net/core/skbuff.c#L1037
reply other threads:[~2014-10-07 8:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5433A1D0.4040803@xsilon.com \
--to=martin.townsend@xsilon.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.