From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mac-hwsim: add ethtool stats support.
Date: Tue, 07 Oct 2014 06:48:42 -0700 [thread overview]
Message-ID: <5433EF3A.5090504@candelatech.com> (raw)
In-Reply-To: <1412671568.1825.1.camel@jlt4.sipsolutions.net>
On 10/07/2014 01:46 AM, Johannes Berg wrote:
> On Thu, 2014-09-25 at 14:22 -0700, greearb@candelatech.com wrote:
>
>> +static const char mac80211_hwsim_gstrings_stats[][ETH_GSTRING_LEN] = {
>> + "tx_pkts_nic",
>> + "tx_bytes_nic",
>> + "rx_pkts_nic",
>> + "rx_bytes_nic",
>> + "d_tx_dropped",
>> + "d_tx_failed",
>> + "d_ps_mode",
>> + "d_group",
>> + "d_tx_power",
>
> What's that d_ prefix?
Stats from the driver v/s from the mac80211 stack. Basically, it
mimics how I did ath9k, ath9k_htc, and ath10k stats (though
not sure ath10k made it upstream yet).
The first 4 match those wifi drivers as well as some Intel wired
NICs.
It doesn't matter a huge amount if you want to change the names,
but it makes user-space stats reporting easier if you would leave
them the same...
Thanks,
Ben
>
> johannes
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-10-07 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 21:22 [PATCH 1/3] mac-hwsim: don't leak memory on tx failure greearb
2014-09-25 21:22 ` [PATCH 2/3] mac-hwsim: add ethtool stats support greearb
2014-10-07 8:46 ` Johannes Berg
2014-10-07 13:48 ` Ben Greear [this message]
2014-10-09 9:44 ` Johannes Berg
2014-09-25 21:22 ` [PATCH 3/3] mac-hwsim: fix typo, remove un-needed goto greearb
2014-10-07 8:46 ` [PATCH 1/3] mac-hwsim: don't leak memory on tx failure Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5433EF3A.5090504@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.