From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH 08/13] xen/dts: make the
 dt_find_property function to be global
Date: Tue, 07 Oct 2014 16:09:57 +0100
Message-ID: <54340245.3070405@linaro.org>
References: <1412691566-7320-1-git-send-email-oleksandr.dmytryshyn@globallogic.com>
	<1412691566-7320-9-git-send-email-oleksandr.dmytryshyn@globallogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1412691566-7320-9-git-send-email-oleksandr.dmytryshyn@globallogic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Oleksandr,

On 10/07/2014 03:19 PM, Oleksandr Dmytryshyn wrote:
> This patch makes possible to use the dt_find_property function
> outside the device tree module.

I can't find any usage of this function within your series. Any reason
to export it?

Regards,

> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>
> ---
>  xen/common/device_tree.c      | 2 +-
>  xen/include/xen/device_tree.h | 9 +++++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index f0bd7b9..5fbb0c1 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -522,7 +522,7 @@ static void __init *unflatten_dt_alloc(unsigned long *mem, unsigned long size,
>  }
>  
>  /* Find a property with a given name for a given node and return it. */
> -static const struct dt_property *
> +const struct dt_property *
>  dt_find_property(const struct dt_device_node *np,
>                   const char *name,
>                   u32 *lenp)
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index 99de53f..508d840 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -344,6 +344,15 @@ struct dt_device_node *dt_find_compatible_node(struct dt_device_node *from,
>  
>  /**
>   * Find a property with a given name for a given node
> + * and return it.
> + */
> +const struct dt_property *dt_find_property(const struct dt_device_node *np,
> +                                           const char *name,
> +                                           u32 *lenp);
> +
> +
> +/**
> + * Find a property with a given name for a given node
>   * and return the value.
>   */
>  const void *dt_get_property(const struct dt_device_node *np,
> 


-- 
Julien Grall