From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH 07/13] xen/arm: enable cpu hotplug
Date: Tue, 07 Oct 2014 16:15:38 +0100
Message-ID: <5434039A.1060203@linaro.org>
References: <1412691566-7320-1-git-send-email-oleksandr.dmytryshyn@globallogic.com>
	<1412691566-7320-8-git-send-email-oleksandr.dmytryshyn@globallogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1412691566-7320-8-git-send-email-oleksandr.dmytryshyn@globallogic.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Oleksandr,

On 10/07/2014 03:19 PM, Oleksandr Dmytryshyn wrote:
> This config is needed for the cpufreq driver.

Can you expand why your really need it? I don't find any usage of those
define except in:
	include/xen/cpumask.h
	include/xen/init.h

Technically, supporting CPU hotplug in Xen ARM will require more than
enabling those defines. I doubt the code is ready for CPU hotplugging
(for instance see setup_virt_paging).

Regards,

> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>
> ---
>  xen/include/asm-arm/config.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> index 5b7b1a8..ca17c79 100644
> --- a/xen/include/asm-arm/config.h
> +++ b/xen/include/asm-arm/config.h
> @@ -203,6 +203,9 @@ extern unsigned long frametable_virt_end;
>  #define GIC_VR_OFFSET 0x6000 /* Virtual Machine CPU interface) */
>  #endif /* __ASSEMBLY__ */
>  
> +#define CONFIG_HOTPLUG 1
> +#define CONFIG_HOTPLUG_CPU 1
> +
>  #endif /* __ARM_CONFIG_H__ */
>  /*
>   * Local variables:
> 


-- 
Julien Grall