All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc64: Increase size of boot string to 1024 bytes
Date: Tue, 07 Oct 2014 19:29:25 +0000	[thread overview]
Message-ID: <54343F15.2040903@oracle.com> (raw)
In-Reply-To: <5433E6C5.9060304@oracle.com>

On 10/07/2014 01:57 PM, David Miller wrote:
> From: Dave Kleikamp <dave.kleikamp@oracle.com>
> Date: Tue, 07 Oct 2014 08:12:37 -0500
> 
>> This is the longest boot string that silo supports.
>>
>> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> 
> Ok, given how the rest of this thread went, the comment needs to
> be adjusted to match reality which is something like:
> 
> /* We limit BARG_LEN to 1024 because this is the size of the
>  * 'barg_out' command line buffer in the SILO bootloader.  And
>  * it trusts bootstr_len over that buffer's size.
>  */
> 
> Right?

I'd leave off the last sentence:

/* We limit BARG_LEN to 1024 because this is the size of the
 * 'barg_out' command line buffer in the SILO bootloader.
 */

  parent reply	other threads:[~2014-10-07 19:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 13:12 [PATCH] sparc64: Increase size of boot string to 1024 bytes Dave Kleikamp
2014-10-07 18:57 ` David Miller
2014-10-07 19:29 ` Dave Kleikamp [this message]
2014-10-07 19:34 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54343F15.2040903@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.