From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH 2/3] drm/exynos: dp: Remove support for unused dptx-phy Date: Wed, 08 Oct 2014 12:10:47 +0900 Message-ID: <5434AB37.1080603@samsung.com> References: <1410786785-9838-1-git-send-email-gautam.vivek@samsung.com> <1410786785-9838-3-git-send-email-gautam.vivek@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vivek Gautam Cc: "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Sean Paul , "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, kishon , cpgs@samsung.com, ajaykumar.rs@samsung.com List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNOuFhCAxMOyblCAwOOydvCAxMTo1NywgVml2ZWsgR2F1dGFtIHdyb3RlOgo+IEhpLAo+ IAo+IAo+IE9uIE1vbiwgU2VwIDE1LCAyMDE0IGF0IDY6NDMgUE0sIFZpdmVrIEdhdXRhbSA8Z2F1 dGFtLnZpdmVrQHNhbXN1bmcuY29tPiB3cm90ZToKPj4gTm93IHRoYXQgd2UgaGF2ZSBtb3ZlZCB0 byBnZW5lcmljIHBoeSBiYXNlZCBiaW5kaW5ncywKPj4gd2UgZG9uJ3QgbmVlZCB0byBoYXZlIGFu eSBjb2RlIHJlbGF0ZWQgdG8gb2xkZXIgZHB0eC1waHkuCj4+IE5vYm9keSBpcyB1c2luZyB0aGlz IGRwdHgtcGh5IGFueW1vcmUsIHNvIHJlbW92aW5nIHRoZQo+PiBzYW1lLgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBWaXZlayBHYXV0YW0gPGdhdXRhbS52aXZla0BzYW1zdW5nLmNvbT4KPj4gQ2M6IEpp bmdvbyBIYW4gPGpnMS5oYW5Ac2Ftc3VuZy5jb20+Cj4+IC0tLQo+IAo+IElzIHNvbWVvbmUgdGFr aW5nIGNhcmUgb2YgdGhpcyBwYXRjaCA/IFdlIGFscmVhZHkgaGF2ZSBnb3QgdGhlIGNvcnJlc3Bv bnNkaW5nCj4gZHAtcGh5IHBhdGNoIG1lcmdlZCwgc28gd2Ugc2hvdWxkIGFsc28gZ2V0IHRoaXMg cGF0Y2ggaW4uCj4gCgpDYW4gYW55b25lIGdpdmUgbWUgdGVzdGVkLWJ5IGFmdGVyIHRlc3Q/IEkg Y2Fubm90IHRlc3QgdGhpcyBtb2R1bGUKYmVjYXVzZSBJIGhhdmUgbm8gYW55IGJvYXJkIGVxdWlw cGVkIHdpdGggZHAgcGFuZWwuCgpKaW5nb28gb3Igb3RoZXI/CgpUaGFua3MsCklua2kgRGFlCgo+ PiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBfY29yZS5jIHwgICA1OCArKysrKysr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5v c19kcF9jb3JlLmggfCAgICAyIC0tCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMo KyksIDQ3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9leHlub3NfZHBfY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBf Y29yZS5jCj4+IGluZGV4IDRmM2M3ZWIuLjVmZmMxYjIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZXh5bm9zL2V4eW5vc19kcF9jb3JlLmMKPj4gQEAgLTEwNTAsMjggKzEwNTAsMTQgQEAgc3RhdGlj IGludCBleHlub3NfZHBfY3JlYXRlX2Nvbm5lY3RvcihzdHJ1Y3QgZXh5bm9zX2RybV9kaXNwbGF5 ICpkaXNwbGF5LAo+Pgo+PiAgc3RhdGljIHZvaWQgZXh5bm9zX2RwX3BoeV9pbml0KHN0cnVjdCBl eHlub3NfZHBfZGV2aWNlICpkcCkKPj4gIHsKPj4gLSAgICAgICBpZiAoZHAtPnBoeSkgewo+PiAr ICAgICAgIGlmIChkcC0+cGh5KQo+PiAgICAgICAgICAgICAgICAgcGh5X3Bvd2VyX29uKGRwLT5w aHkpOwo+PiAtICAgICAgIH0gZWxzZSBpZiAoZHAtPnBoeV9hZGRyKSB7Cj4+IC0gICAgICAgICAg ICAgICB1MzIgcmVnOwo+PiAtCj4+IC0gICAgICAgICAgICAgICByZWcgPSBfX3Jhd19yZWFkbChk cC0+cGh5X2FkZHIpOwo+PiAtICAgICAgICAgICAgICAgcmVnIHw9IGRwLT5lbmFibGVfbWFzazsK Pj4gLSAgICAgICAgICAgICAgIF9fcmF3X3dyaXRlbChyZWcsIGRwLT5waHlfYWRkcik7Cj4+IC0g ICAgICAgfQo+PiAgfQo+Pgo+PiAgc3RhdGljIHZvaWQgZXh5bm9zX2RwX3BoeV9leGl0KHN0cnVj dCBleHlub3NfZHBfZGV2aWNlICpkcCkKPj4gIHsKPj4gLSAgICAgICBpZiAoZHAtPnBoeSkgewo+ PiArICAgICAgIGlmIChkcC0+cGh5KQo+PiAgICAgICAgICAgICAgICAgcGh5X3Bvd2VyX29mZihk cC0+cGh5KTsKPj4gLSAgICAgICB9IGVsc2UgaWYgKGRwLT5waHlfYWRkcikgewo+PiAtICAgICAg ICAgICAgICAgdTMyIHJlZzsKPj4gLQo+PiAtICAgICAgICAgICAgICAgcmVnID0gX19yYXdfcmVh ZGwoZHAtPnBoeV9hZGRyKTsKPj4gLSAgICAgICAgICAgICAgIHJlZyAmPSB+KGRwLT5lbmFibGVf bWFzayk7Cj4+IC0gICAgICAgICAgICAgICBfX3Jhd193cml0ZWwocmVnLCBkcC0+cGh5X2FkZHIp Owo+PiAtICAgICAgIH0KPj4gIH0KPj4KPj4gIHN0YXRpYyB2b2lkIGV4eW5vc19kcF9wb3dlcm9u KHN0cnVjdCBleHlub3NfZHJtX2Rpc3BsYXkgKmRpc3BsYXkpCj4+IEBAIC0xMjEwLDM5ICsxMTk2 LDIxIEBAIHN0YXRpYyBzdHJ1Y3QgdmlkZW9faW5mbyAqZXh5bm9zX2RwX2R0X3BhcnNlX3BkYXRh KHN0cnVjdCBkZXZpY2UgKmRldikKPj4KPj4gIHN0YXRpYyBpbnQgZXh5bm9zX2RwX2R0X3BhcnNl X3BoeWRhdGEoc3RydWN0IGV4eW5vc19kcF9kZXZpY2UgKmRwKQo+PiAgewo+PiAtICAgICAgIHN0 cnVjdCBkZXZpY2Vfbm9kZSAqZHBfcGh5X25vZGUgPSBvZl9ub2RlX2dldChkcC0+ZGV2LT5vZl9u b2RlKTsKPj4gLSAgICAgICB1MzIgcGh5X2Jhc2U7Cj4+ICAgICAgICAgaW50IHJldCA9IDA7Cj4+ Cj4+IC0gICAgICAgZHBfcGh5X25vZGUgPSBvZl9maW5kX25vZGVfYnlfbmFtZShkcF9waHlfbm9k ZSwgImRwdHgtcGh5Iik7Cj4+IC0gICAgICAgaWYgKCFkcF9waHlfbm9kZSkgewo+PiAtICAgICAg ICAgICAgICAgZHAtPnBoeSA9IGRldm1fcGh5X2dldChkcC0+ZGV2LCAiZHAiKTsKPj4gLSAgICAg ICAgICAgICAgIHJldHVybiBQVFJfRVJSX09SX1pFUk8oZHAtPnBoeSk7Cj4+IC0gICAgICAgfQo+ PiAtCj4+IC0gICAgICAgaWYgKG9mX3Byb3BlcnR5X3JlYWRfdTMyKGRwX3BoeV9ub2RlLCAicmVn IiwgJnBoeV9iYXNlKSkgewo+PiAtICAgICAgICAgICAgICAgZGV2X2VycihkcC0+ZGV2LCAiZmFp bGVkIHRvIGdldCByZWcgZm9yIGRwdHgtcGh5XG4iKTsKPj4gLSAgICAgICAgICAgICAgIHJldCA9 IC1FSU5WQUw7Cj4+IC0gICAgICAgICAgICAgICBnb3RvIGVycjsKPj4gLSAgICAgICB9Cj4+IC0K Pj4gLSAgICAgICBpZiAob2ZfcHJvcGVydHlfcmVhZF91MzIoZHBfcGh5X25vZGUsICJzYW1zdW5n LGVuYWJsZS1tYXNrIiwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZHAtPmVu YWJsZV9tYXNrKSkgewo+PiAtICAgICAgICAgICAgICAgZGV2X2VycihkcC0+ZGV2LCAiZmFpbGVk IHRvIGdldCBlbmFibGUtbWFzayBmb3IgZHB0eC1waHlcbiIpOwo+PiAtICAgICAgICAgICAgICAg cmV0ID0gLUVJTlZBTDsKPj4gLSAgICAgICAgICAgICAgIGdvdG8gZXJyOwo+PiAtICAgICAgIH0K Pj4gLQo+PiAtICAgICAgIGRwLT5waHlfYWRkciA9IGlvcmVtYXAocGh5X2Jhc2UsIFNaXzQpOwo+ PiAtICAgICAgIGlmICghZHAtPnBoeV9hZGRyKSB7Cj4+IC0gICAgICAgICAgICAgICBkZXZfZXJy KGRwLT5kZXYsICJmYWlsZWQgdG8gaW9yZW1hcCBkcC1waHlcbiIpOwo+PiAtICAgICAgICAgICAg ICAgcmV0ID0gLUVOT01FTTsKPj4gLSAgICAgICAgICAgICAgIGdvdG8gZXJyOwo+PiArICAgICAg IGRwLT5waHkgPSBkZXZtX3BoeV9nZXQoZHAtPmRldiwgImRwIik7Cj4+ICsgICAgICAgaWYgKElT X0VSUihkcC0+cGh5KSkgewo+PiArICAgICAgICAgICAgICAgcmV0ID0gUFRSX0VSUihkcC0+cGh5 KTsKPj4gKyAgICAgICAgICAgICAgIGlmIChyZXQgPT0gLUVOT1NZUyB8fCByZXQgPT0gLUVOT0RF Vikgewo+PiArICAgICAgICAgICAgICAgICAgICAgICBkcC0+cGh5ID0gTlVMTDsKPj4gKyAgICAg ICAgICAgICAgIH0gZWxzZSBpZiAocmV0ID09IC1FUFJPQkVfREVGRVIpIHsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPj4gKyAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4+ ICsgICAgICAgICAgICAgICAgICAgICAgIGRldl9lcnIoZHAtPmRldiwgIm5vIERQIHBoeSBjb25m aWd1cmVkXG4iKTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPj4gKyAg ICAgICAgICAgICAgIH0KPj4gICAgICAgICB9Cj4+Cj4+IC1lcnI6Cj4+IC0gICAgICAgb2Zfbm9k ZV9wdXQoZHBfcGh5X25vZGUpOwo+PiAtCj4+ICAgICAgICAgcmV0dXJuIHJldDsKPj4gIH0KPj4K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuaCBi L2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuaAo+PiBpbmRleCBhMWFlZTY5 Li42NDI2MjAxIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19k cF9jb3JlLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBfY29yZS5o Cj4+IEBAIC0xNTMsOCArMTUzLDYgQEAgc3RydWN0IGV4eW5vc19kcF9kZXZpY2Ugewo+PiAgICAg ICAgIHN0cnVjdCBjbGsgICAgICAgICAgICAgICpjbG9jazsKPj4gICAgICAgICB1bnNpZ25lZCBp bnQgICAgICAgICAgICBpcnE7Cj4+ICAgICAgICAgdm9pZCBfX2lvbWVtICAgICAgICAgICAgKnJl Z19iYXNlOwo+PiAtICAgICAgIHZvaWQgX19pb21lbSAgICAgICAgICAgICpwaHlfYWRkcjsKPj4g LSAgICAgICB1bnNpZ25lZCBpbnQgICAgICAgICAgICBlbmFibGVfbWFzazsKPj4KPj4gICAgICAg ICBzdHJ1Y3QgdmlkZW9faW5mbyAgICAgICAqdmlkZW9faW5mbzsKPj4gICAgICAgICBzdHJ1Y3Qg bGlua190cmFpbiAgICAgICBsaW5rX3RyYWluOwo+PiAtLQo+PiAxLjcuMTAuNAo+Pgo+IAo+IAo+ IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbaJHDKw (ORCPT ); Tue, 7 Oct 2014 23:10:52 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:25181 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753767AbaJHDKu (ORCPT ); Tue, 7 Oct 2014 23:10:50 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79ab6d0000046f7-7a-5434ab374382 Content-transfer-encoding: 8BIT Message-id: <5434AB37.1080603@samsung.com> Date: Wed, 08 Oct 2014 12:10:47 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Vivek Gautam Cc: dri-devel@lists.freedesktop.org, "linux-samsung-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sean Paul , kishon , ajaykumar.rs@samsung.com, Jingoo Han , cpgs@samsung.com Subject: Re: [PATCH 2/3] drm/exynos: dp: Remove support for unused dptx-phy References: <1410786785-9838-1-git-send-email-gautam.vivek@samsung.com> <1410786785-9838-3-git-send-email-gautam.vivek@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsWyRsSkQNd8tUmIwfyD2hYH3h9ksXh5SNNi /pFzrBZXvr5ns2i7cpDd4vLCS6wWF572sFlc3jWHzWLG+X1MFnMP5jpweSzYVOpxv/s4k0ff llWMHsdvbGfy+LxJLoA1issmJTUnsyy1SN8ugSvj29+nTAVTVCs+911ibmDcINnFyMkhIWAi 0f5hEyOELSZx4d56ti5GLg4hgaWMEnPOX2WFKfrcc4kRIrGIUeJeQyc7SIJXQFDix+R7LF2M HBzMAvISRy5lg4SZBdQlJs1bxAxR/4pR4vGF36wQ9VoS995/A6tnEVCVeHDCEiTMBmROXHGf DcQWFQiTePFqFzOILSKgLbF97iRWkDnMAt+ZJLZePMII0iss4C3x4h4fxPwzjBJTp95hAmng FAgGmvkT7FAJgUfsEsvf94JNZREQkPg2+RDYYgkBWYlNB5ghHpOUOLjiBssERrFZSN6ZhfDO LCTvLGBkXsUomlqQXFCclF5kolecmFtcmpeul5yfu4kRGI2n/z2bsIPx3gHrQ4wCHIxKPLwG zSYhQqyJZcWVuYcYTYGOmMgsJZqcD4z5vJJ4Q2MzIwtTE1NjI3NLMyVx3tdSP4OFBNITS1Kz U1MLUovii0pzUosPMTJxcEo1MBZOXXmTU+jZv5AF15ds3Tun7GSlqPQBiWn+9jcTMtXc9W34 fHi9T/xSslv8Plp8+z5jpgkPH6hIxOd4LE15phplpNcx8+uh/TeOMs+c1MWgfjviAAu346JQ lRjFQ7op9063bCjyMpgVvCLG/PzNOrl1Tju2+6/7snnBu5Kv8hE+RYeXnsxZWajEUpyRaKjF XFScCAA1YrhawQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsVy+t9jAV3z1SYhBpM/KVoceH+QxeLlIU2L +UfOsVpc+fqezaLtykF2i8sLL7FaXHjaw2ZxedccNosZ5/cxWcw9mOvA5bFgU6nH/e7jTB59 W1Yxehy/sZ3J4/MmuQDWqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE 3FRbJRefAF23zBygm5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGd/+ PmUqmKJa8bnvEnMD4wbJLkZODgkBE4nPPZcYIWwxiQv31rN1MXJxCAksYpS419DJDpLgFRCU +DH5HksXIwcHs4C8xJFL2SBhZgF1iUnzFjFD1L9ilHh84TcrRL2WxL3338DqWQRUJR6csAQJ swGZE1fcZwOxRQXCJF682sUMYosIaEtsnzuJFWQOs8B3JomtF48wgvQKC3hLvLjHBzH/DKPE 1Kl3mEAaOAWCgWb+ZJzAKDALyXmzEM6bheS8BYzMqxhFUwuSC4qT0nMN9YoTc4tL89L1kvNz NzGCY/2Z1A7GlQ0WhxgFOBiVeHgNmk1ChFgTy4orcw8xSnAwK4nwRkYDhXhTEiurUovy44tK c1KLDzGaAj03kVlKNDkfmIbySuINjU3MjCyNzA0tjIzNlcR5D7RaBwoJpCeWpGanphakFsH0 MXFwSjUwznqYeXFq4b+U7vX28/Zc2PLjY4iW9CeOHw2qXZYbXJ1/Pjt3ZrvzkrZz5YdOO1d1 mm35OWlX6EXh62u4nb4e/3Oz9H3LRe9TEVXMtUsCRIsTPGe8KbrQfffbrleznsdWpe6+ZyjR 032ivbww/s66l0eidrUkTZUzDRW5Yb+KKUt87YKa6Q7me5VYijMSDbWYi4oTAdYDoMoLAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014년 10월 08일 11:57, Vivek Gautam wrote: > Hi, > > > On Mon, Sep 15, 2014 at 6:43 PM, Vivek Gautam wrote: >> Now that we have moved to generic phy based bindings, >> we don't need to have any code related to older dptx-phy. >> Nobody is using this dptx-phy anymore, so removing the >> same. >> >> Signed-off-by: Vivek Gautam >> Cc: Jingoo Han >> --- > > Is someone taking care of this patch ? We already have got the corresponsding > dp-phy patch merged, so we should also get this patch in. > Can anyone give me tested-by after test? I cannot test this module because I have no any board equipped with dp panel. Jingoo or other? Thanks, Inki Dae >> drivers/gpu/drm/exynos/exynos_dp_core.c | 58 +++++++------------------------ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 2 -- >> 2 files changed, 13 insertions(+), 47 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c >> index 4f3c7eb..5ffc1b2 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >> @@ -1050,28 +1050,14 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display, >> >> static void exynos_dp_phy_init(struct exynos_dp_device *dp) >> { >> - if (dp->phy) { >> + if (dp->phy) >> phy_power_on(dp->phy); >> - } else if (dp->phy_addr) { >> - u32 reg; >> - >> - reg = __raw_readl(dp->phy_addr); >> - reg |= dp->enable_mask; >> - __raw_writel(reg, dp->phy_addr); >> - } >> } >> >> static void exynos_dp_phy_exit(struct exynos_dp_device *dp) >> { >> - if (dp->phy) { >> + if (dp->phy) >> phy_power_off(dp->phy); >> - } else if (dp->phy_addr) { >> - u32 reg; >> - >> - reg = __raw_readl(dp->phy_addr); >> - reg &= ~(dp->enable_mask); >> - __raw_writel(reg, dp->phy_addr); >> - } >> } >> >> static void exynos_dp_poweron(struct exynos_drm_display *display) >> @@ -1210,39 +1196,21 @@ static struct video_info *exynos_dp_dt_parse_pdata(struct device *dev) >> >> static int exynos_dp_dt_parse_phydata(struct exynos_dp_device *dp) >> { >> - struct device_node *dp_phy_node = of_node_get(dp->dev->of_node); >> - u32 phy_base; >> int ret = 0; >> >> - dp_phy_node = of_find_node_by_name(dp_phy_node, "dptx-phy"); >> - if (!dp_phy_node) { >> - dp->phy = devm_phy_get(dp->dev, "dp"); >> - return PTR_ERR_OR_ZERO(dp->phy); >> - } >> - >> - if (of_property_read_u32(dp_phy_node, "reg", &phy_base)) { >> - dev_err(dp->dev, "failed to get reg for dptx-phy\n"); >> - ret = -EINVAL; >> - goto err; >> - } >> - >> - if (of_property_read_u32(dp_phy_node, "samsung,enable-mask", >> - &dp->enable_mask)) { >> - dev_err(dp->dev, "failed to get enable-mask for dptx-phy\n"); >> - ret = -EINVAL; >> - goto err; >> - } >> - >> - dp->phy_addr = ioremap(phy_base, SZ_4); >> - if (!dp->phy_addr) { >> - dev_err(dp->dev, "failed to ioremap dp-phy\n"); >> - ret = -ENOMEM; >> - goto err; >> + dp->phy = devm_phy_get(dp->dev, "dp"); >> + if (IS_ERR(dp->phy)) { >> + ret = PTR_ERR(dp->phy); >> + if (ret == -ENOSYS || ret == -ENODEV) { >> + dp->phy = NULL; >> + } else if (ret == -EPROBE_DEFER) { >> + return ret; >> + } else { >> + dev_err(dp->dev, "no DP phy configured\n"); >> + return ret; >> + } >> } >> >> -err: >> - of_node_put(dp_phy_node); >> - >> return ret; >> } >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h >> index a1aee69..6426201 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.h >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h >> @@ -153,8 +153,6 @@ struct exynos_dp_device { >> struct clk *clock; >> unsigned int irq; >> void __iomem *reg_base; >> - void __iomem *phy_addr; >> - unsigned int enable_mask; >> >> struct video_info *video_info; >> struct link_train link_train; >> -- >> 1.7.10.4 >> > > >