From: heiner.kallweit@web.de (Heiner Kallweit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx: thermal: imx_get_temp might be called before the sensor clock ist prepared
Date: Wed, 08 Oct 2014 07:27:33 +0200 [thread overview]
Message-ID: <5434CB45.1040509@web.de> (raw)
In-Reply-To: <CAOMZO5CctOy9d79L33Lo7n4y+_aBszT8uKiGcOzmHe-6VfVmog@mail.gmail.com>
OK, I'll submit a revised patch with improved error path.
Regards, Heiner
Am 07.10.2014 um 21:42 schrieb Fabio Estevam:
> Hi Heiner,
>
> On Tue, Oct 7, 2014 at 4:36 PM, Heiner Kallweit <heiner.kallweit@web.de> wrote:
>> Thanks for the hint, Philipp.
>> After thinking a little bit more about it I'm not sure about one thing:
>>
>> If we can't get the clock or fail to enable it: Currently the code just throws
>> a warning and proceeds with trying to register the thermal device.
>> Does this make sense or shall we bail out instead (like in case of other error conditions
>> in imx_thermal_probe)? I'd tend to bail out ..
>
> Agree with you. We should do a 'return ret' if clk_prepare_enable()
> fails. Thanks
>
next prev parent reply other threads:[~2014-10-08 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 18:37 [PATCH] imx: thermal: imx_get_temp might be called before the sensor clock ist prepared Heiner Kallweit
2014-10-07 13:04 ` Philipp Zabel
2014-10-07 19:36 ` Heiner Kallweit
2014-10-07 19:42 ` Fabio Estevam
2014-10-08 5:27 ` Heiner Kallweit [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-06 18:34 [Patch] " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5434CB45.1040509@web.de \
--to=heiner.kallweit@web.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.