From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ser2net: Add a hash file
Date: Wed, 8 Oct 2014 10:25:36 +0100 [thread overview]
Message-ID: <54350310.8060802@imgtec.com> (raw)
In-Reply-To: <20141008112001.2e0b8b9b@free-electrons.com>
Dear Thomas Petazzoni,
On 10/08/2014 10:20 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Wed, 8 Oct 2014 09:57:39 +0100, Vicente Olivert Riera wrote:
>
>>> Why having all those hashes?
>>
>> Why not? Those are all the hashes supported in Buildroot. The more we
>> have the better.
>
> I disagree: more hashes means more work to do when bumping the package.
> Either one strong hash, or two weaker hashes should be sufficient IMO.
More work? I disagree. I created the hash file with a one-liner command:
for i in md5 sha1 sha224 sha256 sha384 sha512; do echo $i `${i}sum
ser2net-2.10.0.tar.gz` >> ../package/ser2net/ser2net.hash; done
> Something to be discussed at the meeting maybe?
>
>>> And the comment indicating how they have
>>> been found is missing (locally computed? found on the upstream web
>>> site).
>>
>> I haven't added any comment because those hashes were locally computed.
>> Do I need to add a comment explain that?
>
> Yes, I believe so.
No problem, I can resend the patch adding that comment. Or maybe it's
easier if you or Peter do it, since is a trivial change and you are the
ones who will commit the patch at the end.
> Best regards,
>
> Thomas
>
--
Vincent
next prev parent reply other threads:[~2014-10-08 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 14:30 [Buildroot] [PATCH] ser2net: Fix compilation failures due to missing TIOCSRS485 macro Vicente Olivert Riera
2014-10-07 14:30 ` [Buildroot] [PATCH] ser2net: Add a hash file Vicente Olivert Riera
2014-10-07 17:23 ` Thomas Petazzoni
2014-10-08 8:57 ` Vicente Olivert Riera
2014-10-08 9:20 ` Thomas Petazzoni
2014-10-08 9:25 ` Vicente Olivert Riera [this message]
2014-10-08 9:37 ` Markos Chandras
2014-10-08 9:41 ` Vicente Olivert Riera
2014-10-08 10:04 ` Peter Korsgaard
2014-10-08 10:11 ` Gustavo Zacarias
2014-10-08 10:18 ` Markos Chandras
2014-10-08 10:43 ` Gustavo Zacarias
2014-10-08 11:25 ` Markos Chandras
2014-10-08 11:35 ` Gustavo Zacarias
2014-10-29 21:58 ` Thomas Petazzoni
2014-10-07 14:33 ` [Buildroot] [PATCH] ser2net: Fix compilation failures due to missing TIOCSRS485 macro Yegor Yefremov
2014-10-07 17:28 ` Thomas Petazzoni
2014-10-07 19:34 ` Yegor Yefremov
2014-10-07 20:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54350310.8060802@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.