From: Bart Tanghe <bart.tanghe@thomasmore.be>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: matt.porter@linaro.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v7]pwm: add BCM2835 PWM driver
Date: Wed, 08 Oct 2014 16:02:49 +0200 [thread overview]
Message-ID: <54354409.7090105@thomasmore.be> (raw)
In-Reply-To: <20141008121935.GB7357@ulmo.nvidia.com>
On 2014-10-08 14:19, Thierry Reding wrote:
> On Wed, Oct 08, 2014 at 12:14:32PM +0200, Bart Tanghe wrote:
>> Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi)
>>
>> Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be>
>> ---
>> Changed in v7:
>> - clean up the shameful clk_enable error handling introduced in v6
>> - clean up the code nits
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
>> new file mode 100644
>> index 0000000..d5162db
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
>> @@ -0,0 +1,27 @@
>> +BCM2835 PWM controller (Raspberry Pi controller)
>> +
>> +Required properties:
>> +- compatible: should be "brcm,bcm2835-pwm"
>> +- reg: physical base address and length of the controller's registers
>> +- clock: this clock defines the base clock frequency of the pwm
>> +hardware system, the period and the duty_cycle of the pwm signal is a
>> +multiple of the base period
>
> This needs to document the #pwm-cells property. I can fix that up when
> applying, though.
>
> Let's give Stephen and others a chance to give this another look.
>
> Thierry
>
Perfect, thanks.
Bart
next prev parent reply other threads:[~2014-10-08 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 10:14 [PATCH v7]pwm: add BCM2835 PWM driver Bart Tanghe
2014-10-08 12:19 ` Thierry Reding
2014-10-08 14:02 ` Bart Tanghe [this message]
2014-10-08 16:30 ` Stephen Warren
2014-10-14 13:54 ` Thierry Reding
2014-10-15 10:33 ` Bart Tanghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54354409.7090105@thomasmore.be \
--to=bart.tanghe@thomasmore.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=matt.porter@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.