All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lan Tianyu <tianyu.lan@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, rafael.j.wysocki@intel.com, toshi.kani@hp.com,
	akpm@linux-foundation.org, ktkhai@parallels.com, fabf@skynet.be,
	laijs@cn.fujitsu.com, srivatsa.bhat@linux.vnet.ibm.com,
	ego@linux.vnet.ibm.com, srivatsa@mit.edu,
	viresh.kumar@linaro.org, todd.e.brandt@linux.intel.com,
	tipbot@zytor.com, wangyun@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH V3 0/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices
Date: Thu, 09 Oct 2014 09:18:45 +0800	[thread overview]
Message-ID: <5435E275.3030307@intel.com> (raw)
In-Reply-To: <20141008205441.GJ4750@worktop.programming.kicks-ass.net>

On 2014年10月09日 04:54, Peter Zijlstra wrote:
> On Thu, Sep 25, 2014 at 04:32:02PM +0800, Lan Tianyu wrote:
>> This patchset is to parallel enabling nonboot cpus with resuming devices
>> during system resume in order to accelerate S2RAM. From test result on
>> a 8 logical core Haswell machine, system resume time reduces from 347ms
>> to 217ms with this patchset.
>>
>> In the current world, all nonboot cpus are enabled serially during system
>> resume. System resume sequence is that boot cpu enables nonboot cpu one by
>> one and then resume devices. Before resuming devices, there are few tasks
>> assigned to nonboot cpus after they are brought up. This wastes cpu usage.
>>
>> This patchset is to allow boot cpu to go forward to resume devices after
>> bringing up one nonboot cpu and starting a thread. The thread will be in
>> charge of bringing up other frozen cpus. The thread will be scheduled to
>> the first online cpu to run . This makes enabling cpu2~x parallel with
>> resuming devices.
> 
> So I feel we should really clean up hotplug before doing anything like
> this. Its a trainwreck and just piling more and more hacks ontop isn't
> going to help any.
> 

Hi Peter:
	Sorry, I don't know the gap of hotplug clearly. Could you elaborate it?
-- 
Best regards
Tianyu Lan

  parent reply	other threads:[~2014-10-09  1:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  8:32 [RFC PATCH V3 0/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices Lan Tianyu
2014-09-25  8:32 ` [RFC PATCH V3 1/3] " Lan Tianyu
2014-09-25  8:32 ` [RFC PATCH V2 2/3] X86/CPU: Initialize MTRR/PAT when each cpu is online during system resume Lan Tianyu
2014-09-25  8:32 ` [RFC PATCH V3 3/3] Cpufreq: Hold cpu_add_remove_lock before change cpufreq_suspended flag Lan Tianyu
2014-10-08 20:54 ` [RFC PATCH V3 0/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices Peter Zijlstra
2014-10-08 22:01   ` Rafael J. Wysocki
2014-10-09  1:18   ` Lan Tianyu [this message]
2014-10-22  6:06     ` Lan Tianyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5435E275.3030307@intel.com \
    --to=tianyu.lan@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ego@linux.vnet.ibm.com \
    --cc=fabf@skynet.be \
    --cc=ktkhai@parallels.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=srivatsa@mit.edu \
    --cc=tglx@linutronix.de \
    --cc=tipbot@zytor.com \
    --cc=todd.e.brandt@linux.intel.com \
    --cc=toshi.kani@hp.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wangyun@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.