From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-xen-4.5 v3 02/16] x86/boot/reloc: Move
 typedef and include to beginning of file
Date: Thu, 9 Oct 2014 10:40:29 +0100
Message-ID: <5436580D.9020703@citrix.com>
References: <1412790736-28915-1-git-send-email-daniel.kiper@oracle.com>
	<1412790736-28915-3-git-send-email-daniel.kiper@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1XcADY-0007kC-4U
	for xen-devel@lists.xenproject.org; Thu, 09 Oct 2014 09:41:04 +0000
In-Reply-To: <1412790736-28915-3-git-send-email-daniel.kiper@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel Kiper <daniel.kiper@oracle.com>, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, roy.franz@linaro.org, ning.sun@intel.com, jbeulich@suse.com, ross.philipson@citrix.com, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org
List-Id: xen-devel@lists.xenproject.org

On 08/10/14 18:52, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

(FWIW, this would be find IMO folded into the previous patch as part of
a "misc cleanup to reloc.c" patch)

> ---
>  xen/arch/x86/boot/reloc.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
> index 4609e55..0c03291 100644
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -10,6 +10,10 @@
>   *    Keir Fraser <keir@xen.org>
>   */
>  
> +typedef unsigned int u32;
> +
> +#include "../../../include/xen/multiboot.h"
> +
>  /* entered with %eax = BOOT_TRAMPOLINE */
>  asm (
>      "    .text                         \n"
> @@ -30,9 +34,6 @@ asm (
>      "    .long 0                       \n"
>      );
>  
> -typedef unsigned int u32;
> -#include "../../../include/xen/multiboot.h"
> -
>  static void *reloc_mbi_struct(void *old, unsigned int bytes)
>  {
>      void *new;