From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghavendra K T Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant Date: Thu, 09 Oct 2014 15:12:30 +0530 Message-ID: <54365886.7010506@linux.vnet.ibm.com> References: <54361922.8070808@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54361922.8070808-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Preeti U Murthy Cc: svaidy-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Peter Zijlstra , rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, Anton Blanchard , Tejun Heo , Paul McKenney , Ingo Molnar , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List On 10/09/2014 10:42 AM, Preeti U Murthy wrote: > Hi Raghu, > remove_tasks_in_empty_cpuset() is called on the legacy hierarchy when > the cpuset becomes empty, hence we require it. But you are right its not > called on the default hierarchy. My point was if legacy hierarchy follows unified hierarchy in effective cpuset handling, we will never endup with a empty effective cpuset and hence your patch could remove the remove_tasks_in_empty_cpuset() part too.. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753439AbaJIJmh (ORCPT ); Thu, 9 Oct 2014 05:42:37 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:41978 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbaJIJm3 (ORCPT ); Thu, 9 Oct 2014 05:42:29 -0400 Message-ID: <54365886.7010506@linux.vnet.ibm.com> Date: Thu, 09 Oct 2014 15:12:30 +0530 From: Raghavendra K T Organization: IBM User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Preeti U Murthy CC: svaidy@linux.vnet.ibm.com, Peter Zijlstra , rjw@rjwysocki.net, lizefan@huawei.com, Anton Blanchard , Tejun Heo , Paul McKenney , Ingo Molnar , cgroups@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant References: <54361922.8070808@linux.vnet.ibm.com> In-Reply-To: <54361922.8070808@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14100909-4790-0000-0000-0000042E9DC9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2014 10:42 AM, Preeti U Murthy wrote: > Hi Raghu, > remove_tasks_in_empty_cpuset() is called on the legacy hierarchy when > the cpuset becomes empty, hence we require it. But you are right its not > called on the default hierarchy. My point was if legacy hierarchy follows unified hierarchy in effective cpuset handling, we will never endup with a empty effective cpuset and hence your patch could remove the remove_tasks_in_empty_cpuset() part too..