From: Michael Tokarev <mjt@tls.msk.ru>
To: "Arend van Spriel" <arend@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Cc: Maximilian Engelhardt <maxi@daemonizer.de>,
Seth Forshee <seth.forshee@canonical.com>,
brcm80211 development <brcm80211-dev-list@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH][RTF][RFC] brcmsmac: add workaround for old BCM4313 devices with Bluetooth
Date: Thu, 09 Oct 2014 14:28:02 +0400 [thread overview]
Message-ID: <54366332.9060906@msgid.tls.msk.ru> (raw)
In-Reply-To: <543661E1.3050606@broadcom.com>
09.10.2014 14:22, Arend van Spriel wrote:
> I know where the function should be called according our driver and guess what:
>
> if (bfl& BFL_FEM&& chip == 4313) {
Can you fix whitespace there too, and add parens around the & operation, while at it?
> if (!(boardrev>= 0x1250 && bfl& BFL_FEM_BT))
The same here.
> ai_epa_4313war(wlc_hw->sih);
> + else
> + ai_btcombo_p250_4313_war(wlc_hw->sih);
> }
I'll try the patch with my 4313 in a few days, hopefully (I'll have to disassemble
my notebook again).
/mjt
next prev parent reply other threads:[~2014-10-09 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 8:37 [PATCH][RTF][RFC] brcmsmac: add workaround for old BCM4313 devices with Bluetooth Rafał Miłecki
2014-10-09 9:02 ` Rafał Miłecki
2014-10-09 9:46 ` Arend van Spriel
2014-10-09 10:11 ` Rafał Miłecki
2014-10-09 10:22 ` Arend van Spriel
2014-10-09 10:28 ` Michael Tokarev [this message]
2014-10-09 10:37 ` Rafał Miłecki
2014-10-09 10:46 ` Arend van Spriel
2014-10-09 10:46 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54366332.9060906@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=seth.forshee@canonical.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.