From: Dinh Nguyen <dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] reset: socfpga: use arch_initcall for early initialization
Date: Thu, 9 Oct 2014 08:16:18 -0500 [thread overview]
Message-ID: <54368AA2.9000104@opensource.altera.com> (raw)
In-Reply-To: <1412845410.6809.3.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Hi Philipp,
On 10/9/14, 4:03 AM, Philipp Zabel wrote:
> Am Mittwoch, den 08.10.2014, 21:44 -0500 schrieb
> dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org:
>> From: Dinh Nguyen <dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
>>
>> There are certain drivers that are required to get loaded very early using
>> arch_initcall. An example of such a driver is the SOCFPGA's FPGA bridge driver.
>> This driver has to get loaded early because it needs to enable FPGA components
>> that are connected to the bridge.
>>
>> This FPGA bridge driver will using the reset controller API to toggle it's
>> reset bits, thus, it needs the reset driver to be loaded as early as possible
>> in order for it to get used properly.
>
> Without knowing the details, this sounds like the wrong approach. Can't
> the bridge driver return -EPROBE_DEFER until the reset controller is
> available?
>
The bridge driver is also using arch_initcall, as it also needs to get
loaded early for FPGA IPs to work, and so later driver loading will work
for the FPGA IPs.
Dinh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: <dinh.linux@gmail.com>, <s.trumtrar@pengutronix.de>,
<grant.likely@linaro.org>, <robh+dt@kernel.org>,
<atull@opensource.altera.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reset: socfpga: use arch_initcall for early initialization
Date: Thu, 9 Oct 2014 08:16:18 -0500 [thread overview]
Message-ID: <54368AA2.9000104@opensource.altera.com> (raw)
In-Reply-To: <1412845410.6809.3.camel@pengutronix.de>
Hi Philipp,
On 10/9/14, 4:03 AM, Philipp Zabel wrote:
> Am Mittwoch, den 08.10.2014, 21:44 -0500 schrieb
> dinguyen@opensource.altera.com:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> There are certain drivers that are required to get loaded very early using
>> arch_initcall. An example of such a driver is the SOCFPGA's FPGA bridge driver.
>> This driver has to get loaded early because it needs to enable FPGA components
>> that are connected to the bridge.
>>
>> This FPGA bridge driver will using the reset controller API to toggle it's
>> reset bits, thus, it needs the reset driver to be loaded as early as possible
>> in order for it to get used properly.
>
> Without knowing the details, this sounds like the wrong approach. Can't
> the bridge driver return -EPROBE_DEFER until the reset controller is
> available?
>
The bridge driver is also using arch_initcall, as it also needs to get
loaded early for FPGA IPs to work, and so later driver loading will work
for the FPGA IPs.
Dinh
next prev parent reply other threads:[~2014-10-09 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 2:44 [PATCH] reset: socfpga: use arch_initcall for early initialization dinguyen
2014-10-09 2:44 ` dinguyen
[not found] ` <1412822646-11257-1-git-send-email-dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-09 9:03 ` Philipp Zabel
2014-10-09 9:03 ` Philipp Zabel
[not found] ` <1412845410.6809.3.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-10-09 13:16 ` Dinh Nguyen [this message]
2014-10-09 13:16 ` Dinh Nguyen
[not found] ` <54368AA2.9000104-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-10-09 13:28 ` Steffen Trumtrar
2014-10-09 13:28 ` Steffen Trumtrar
2014-10-09 14:57 ` atull
2014-10-09 14:57 ` atull
2014-10-09 15:19 ` Steffen Trumtrar
2014-10-09 15:19 ` Steffen Trumtrar
[not found] ` <20141009151935.GK15799-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-10-10 16:32 ` atull
2014-10-10 16:32 ` atull
2014-10-14 18:45 ` atull
2014-10-14 18:45 ` atull
2014-10-15 10:02 ` Steffen Trumtrar
2014-10-15 13:53 ` Dinh Nguyen
2014-10-15 13:53 ` Dinh Nguyen
2014-10-18 9:22 ` Arnd Bergmann
2014-10-12 14:30 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54368AA2.9000104@opensource.altera.com \
--to=dinguyen-yzvpicuk2abmcg4ihk0kfoh6mc4mb0vx@public.gmane.org \
--cc=atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.