From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler Date: Thu, 09 Oct 2014 06:26:46 -0700 Message-ID: <54368D16.40404@roeck-us.net> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> <20141009104927.GN20647@lee--X1> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=OJkOOOjoSCJAoX6hUrbIyW6edYq7axz1pXjIZbR5du0=; b=qgaFG7XUC9HTWLAw4Hzf9hSOnExxebplFuNfEXZDq1P6fk/3PczzsPFhjrqxPr2SC7szcyqlr8pYhH1PFsDcHPOB51oaUp0WzsVCTVxdJYSiZRDVOrL5dCw/Gpk8+S5EnO0H2/4S+/WnJxa243qp48YBc+eb40sXhZyb0MxnhFI=; In-Reply-To: <20141009104927.GN20647@lee--X1> Sender: linux-alpha-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Lee Jones , Catalin Marinas Cc: "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , Linus Walleij , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "devicetree@vger.kernel.org" On 10/09/2014 03:49 AM, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > >> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: >>> On Mon, 06 Oct 2014, Guenter Roeck wrote: >>>> --- a/drivers/mfd/ab8500-sysctrl.c >>>> +++ b/drivers/mfd/ab8500-sysctrl.c >>>> @@ -6,6 +6,7 @@ >>> >>> [...] >>> >>>> +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, >>>> + void *unused2) >>>> { >>>> sigset_t old; >>>> sigset_t all; >>>> @@ -34,11 +36,6 @@ static void ab8500_power_off(void) >>>> struct power_supply *psy; >>>> int ret; >>>> >>>> - if (sysctrl_dev == NULL) { >>>> - pr_err("%s: sysctrl not initialized\n", __func__); >>>> - return; >>>> - } >>> >>> Can you explain the purpose of this change please? >> >> I guess it's because the sysctrl_dev is already initialised when >> registering the power_off handler, so there isn't a way to call the >> above function with a NULL sysctrl_dev. Probably even with the original >> code you didn't need this check (after some race fix in >> ab8500_sysctrl_remove but races is one of the things Guenter's patches >> try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Sure, no problem. I'll split this into two patches. Since we are at it, any idea what to do with the restart function in the same file ? It is not used anywhere. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Thu, 09 Oct 2014 13:26:46 +0000 Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler Message-Id: <54368D16.40404@roeck-us.net> List-Id: References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> <20141009104927.GN20647@lee--X1> In-Reply-To: <20141009104927.GN20647@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones , Catalin Marinas Cc: "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , Linus Walleij , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "devicetree@vger.kernel.org" On 10/09/2014 03:49 AM, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > >> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: >>> On Mon, 06 Oct 2014, Guenter Roeck wrote: >>>> --- a/drivers/mfd/ab8500-sysctrl.c >>>> +++ b/drivers/mfd/ab8500-sysctrl.c >>>> @@ -6,6 +6,7 @@ >>> >>> [...] >>> >>>> +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, >>>> + void *unused2) >>>> { >>>> sigset_t old; >>>> sigset_t all; >>>> @@ -34,11 +36,6 @@ static void ab8500_power_off(void) >>>> struct power_supply *psy; >>>> int ret; >>>> >>>> - if (sysctrl_dev = NULL) { >>>> - pr_err("%s: sysctrl not initialized\n", __func__); >>>> - return; >>>> - } >>> >>> Can you explain the purpose of this change please? >> >> I guess it's because the sysctrl_dev is already initialised when >> registering the power_off handler, so there isn't a way to call the >> above function with a NULL sysctrl_dev. Probably even with the original >> code you didn't need this check (after some race fix in >> ab8500_sysctrl_remove but races is one of the things Guenter's patches >> try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Sure, no problem. I'll split this into two patches. Since we are at it, any idea what to do with the restart function in the same file ? It is not used anywhere. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 09 Oct 2014 15:28:29 +0200 (CEST) Received: from bh-25.webhostbox.net ([208.91.199.152]:34882 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010944AbaJIN22SupHE (ORCPT ); Thu, 9 Oct 2014 15:28:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=OJkOOOjoSCJAoX6hUrbIyW6edYq7axz1pXjIZbR5du0=; b=qgaFG7XUC9HTWLAw4Hzf9hSOnExxebplFuNfEXZDq1P6fk/3PczzsPFhjrqxPr2SC7szcyqlr8pYhH1PFsDcHPOB51oaUp0WzsVCTVxdJYSiZRDVOrL5dCw/Gpk8+S5EnO0H2/4S+/WnJxa243qp48YBc+eb40sXhZyb0MxnhFI=; Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1XcDlW-000mC4-7k for linux-mips@linux-mips.org; Thu, 09 Oct 2014 13:28:22 +0000 Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:36594 helo=server.roeck-us.net) by bh-25.webhostbox.net with esmtpsa (TLSv1:DHE-RSA-AES128-SHA:128) (Exim 4.82) (envelope-from ) id 1XcDk3-000kvG-OJ; Thu, 09 Oct 2014 13:26:52 +0000 Message-ID: <54368D16.40404@roeck-us.net> Date: Thu, 09 Oct 2014 06:26:46 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Lee Jones , Catalin Marinas CC: "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , Linus Walleij , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "devicetree@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "linux-pm@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "linux-m68k@vger.kernel.org" , "linux-am33-list@redhat.com" , "linux-tegra@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "linux-metag@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Samuel Ortiz , "linux-parisc@vger.kernel.org" , "linux-cris-kernel@axis.com" , "linux-kernel@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> <20141009104927.GN20647@lee--X1> In-Reply-To: <20141009104927.GN20647@lee--X1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020203.54368D76.00C0,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 111 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - linux-mips.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43130 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: linux@roeck-us.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/09/2014 03:49 AM, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > >> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: >>> On Mon, 06 Oct 2014, Guenter Roeck wrote: >>>> --- a/drivers/mfd/ab8500-sysctrl.c >>>> +++ b/drivers/mfd/ab8500-sysctrl.c >>>> @@ -6,6 +6,7 @@ >>> >>> [...] >>> >>>> +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, >>>> + void *unused2) >>>> { >>>> sigset_t old; >>>> sigset_t all; >>>> @@ -34,11 +36,6 @@ static void ab8500_power_off(void) >>>> struct power_supply *psy; >>>> int ret; >>>> >>>> - if (sysctrl_dev == NULL) { >>>> - pr_err("%s: sysctrl not initialized\n", __func__); >>>> - return; >>>> - } >>> >>> Can you explain the purpose of this change please? >> >> I guess it's because the sysctrl_dev is already initialised when >> registering the power_off handler, so there isn't a way to call the >> above function with a NULL sysctrl_dev. Probably even with the original >> code you didn't need this check (after some race fix in >> ab8500_sysctrl_remove but races is one of the things Guenter's patches >> try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Sure, no problem. I'll split this into two patches. Since we are at it, any idea what to do with the restart function in the same file ? It is not used anywhere. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler Date: Thu, 09 Oct 2014 06:26:46 -0700 Message-ID: <54368D16.40404@roeck-us.net> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> <20141009104927.GN20647@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Cc: "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , Linus Walleij , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "devicetree@vger.kernel.org" , Catalin Marinas Return-path: In-Reply-To: <20141009104927.GN20647@lee--X1> List-ID: List-Id: linux-parisc.vger.kernel.org On 10/09/2014 03:49 AM, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > >> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: >>> On Mon, 06 Oct 2014, Guenter Roeck wrote: >>>> --- a/drivers/mfd/ab8500-sysctrl.c >>>> +++ b/drivers/mfd/ab8500-sysctrl.c >>>> @@ -6,6 +6,7 @@ >>> >>> [...] >>> >>>> +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, >>>> + void *unused2) >>>> { >>>> sigset_t old; >>>> sigset_t all; >>>> @@ -34,11 +36,6 @@ static void ab8500_power_off(void) >>>> struct power_supply *psy; >>>> int ret; >>>> >>>> - if (sysctrl_dev == NULL) { >>>> - pr_err("%s: sysctrl not initialized\n", __func__); >>>> - return; >>>> - } >>> >>> Can you explain the purpose of this change please? >> >> I guess it's because the sysctrl_dev is already initialised when >> registering the power_off handler, so there isn't a way to call the >> above function with a NULL sysctrl_dev. Probably even with the original >> code you didn't need this check (after some race fix in >> ab8500_sysctrl_remove but races is one of the things Guenter's patches >> try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Sure, no problem. I'll split this into two patches. Since we are at it, any idea what to do with the restart function in the same file ? It is not used anywhere. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net (bh-25.webhostbox.net [208.91.199.152]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id F0FD91A0AA4 for ; Fri, 10 Oct 2014 00:26:53 +1100 (EST) Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1XcDk4-000kwV-6q for linuxppc-dev@lists.ozlabs.org; Thu, 09 Oct 2014 13:26:52 +0000 Message-ID: <54368D16.40404@roeck-us.net> Date: Thu, 09 Oct 2014 06:26:46 -0700 From: Guenter Roeck MIME-Version: 1.0 To: Lee Jones , Catalin Marinas Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> <20141009104927.GN20647@lee--X1> In-Reply-To: <20141009104927.GN20647@lee--X1> Content-Type: text/plain; charset=utf-8; format=flowed Cc: "linux-m32r-ja@ml.linux-m32r.org" , "linux-mips@linux-mips.org" , "linux-m68k@vger.kernel.org" , "linux-efi@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-sh@vger.kernel.org" , Linus Walleij , "devicetree@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-s390@vger.kernel.org" , "lguest@lists.ozlabs.org" , "linux-c6x-dev@linux-c6x.org" , "linux-hexagon@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "linux-xtensa@linux-xtensa.org" , "user-mode-linux-devel@lists.sourceforge.net" , "linux-pm@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , "linux-am33-list@redhat.com" , "linux-tegra@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "linux-metag@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Samuel Ortiz , "linux-cris-kernel@axis.com" , "linux-parisc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/09/2014 03:49 AM, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > >> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: >>> On Mon, 06 Oct 2014, Guenter Roeck wrote: >>>> --- a/drivers/mfd/ab8500-sysctrl.c >>>> +++ b/drivers/mfd/ab8500-sysctrl.c >>>> @@ -6,6 +6,7 @@ >>> >>> [...] >>> >>>> +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, >>>> + void *unused2) >>>> { >>>> sigset_t old; >>>> sigset_t all; >>>> @@ -34,11 +36,6 @@ static void ab8500_power_off(void) >>>> struct power_supply *psy; >>>> int ret; >>>> >>>> - if (sysctrl_dev == NULL) { >>>> - pr_err("%s: sysctrl not initialized\n", __func__); >>>> - return; >>>> - } >>> >>> Can you explain the purpose of this change please? >> >> I guess it's because the sysctrl_dev is already initialised when >> registering the power_off handler, so there isn't a way to call the >> above function with a NULL sysctrl_dev. Probably even with the original >> code you didn't need this check (after some race fix in >> ab8500_sysctrl_remove but races is one of the things Guenter's patches >> try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Sure, no problem. I'll split this into two patches. Since we are at it, any idea what to do with the restart function in the same file ? It is not used anywhere. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 09 Oct 2014 06:26:46 -0700 Subject: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler In-Reply-To: <20141009104927.GN20647@lee--X1> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-13-git-send-email-linux@roeck-us.net> <20141007080048.GB25331@lee--X1> <20141009103656.GF17836@e104818-lin.cambridge.arm.com> <20141009104927.GN20647@lee--X1> Message-ID: <54368D16.40404@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/09/2014 03:49 AM, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > >> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: >>> On Mon, 06 Oct 2014, Guenter Roeck wrote: >>>> --- a/drivers/mfd/ab8500-sysctrl.c >>>> +++ b/drivers/mfd/ab8500-sysctrl.c >>>> @@ -6,6 +6,7 @@ >>> >>> [...] >>> >>>> +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, >>>> + void *unused2) >>>> { >>>> sigset_t old; >>>> sigset_t all; >>>> @@ -34,11 +36,6 @@ static void ab8500_power_off(void) >>>> struct power_supply *psy; >>>> int ret; >>>> >>>> - if (sysctrl_dev == NULL) { >>>> - pr_err("%s: sysctrl not initialized\n", __func__); >>>> - return; >>>> - } >>> >>> Can you explain the purpose of this change please? >> >> I guess it's because the sysctrl_dev is already initialised when >> registering the power_off handler, so there isn't a way to call the >> above function with a NULL sysctrl_dev. Probably even with the original >> code you didn't need this check (after some race fix in >> ab8500_sysctrl_remove but races is one of the things Guenter's patches >> try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Sure, no problem. I'll split this into two patches. Since we are at it, any idea what to do with the restart function in the same file ? It is not used anywhere. Guenter