From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v4] Separate runtime debug output from debug symbols Date: Thu, 9 Oct 2014 15:58:10 +0100 Message-ID: <5436A282.6060604@citrix.com> References: <1412841518-19044-1-git-send-email-olaf@aepfle.de> <5436A49B02000078000BEF1F@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5436A49B02000078000BEF1F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , olaf@aepfle.de, xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, samuel.thibault@ens-lyon.org, keir@xen.org, dave.scott@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 09/10/14 15:07, Jan Beulich wrote: >>>> Olaf Hering 10/09/14 9:59 AM >>> >> --- a/Config.mk >> +++ b/Config.mk >> @@ -18,7 +18,7 @@ or = $(if $(strip $(1)),$(1),$(if $(strip $(2)),$(2),$(if $(strip $(3)),$( > > >> # A debug build of Xen and tools? >> debug ?= y >> -debug_symbols ?= $(debug) >> +debug_symbols ?= y > > Even if this may be what Ian asked you to do (albeit it's not entirely clear > to me), I don't think I'm in agreement with this change being done: I > personally expect to be able to disable debug_symbols as a side effect > of disabling debug. > > Jan Agreed, which is why I (as the author of the debug_symbols change) left it that way. FWIW, I believe that v3 of this patch is correct. I did not follow the reasoning for the objection. Anyone building for themselves will (should) be doing debug builds. Anyone packaging RPMs will want debug_symbols enabled to generate -debuginfo RPMs. I presume .debs have a similar principle. ~Andrew