From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1XcHpn-0006K0-Fj
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 13:49:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1XcHpg-0002ns-0n
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 13:49:03 -0400
Received: from mail-oi0-f53.google.com ([209.85.218.53]:40150)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1XcHpf-0002nC-S5
	for qemu-devel@nongnu.org; Thu, 09 Oct 2014 13:48:55 -0400
Received: by mail-oi0-f53.google.com with SMTP id v63so3882786oia.40
	for <qemu-devel@nongnu.org>; Thu, 09 Oct 2014 10:48:54 -0700 (PDT)
Message-ID: <5436CA84.5070804@mvista.com>
Date: Thu, 09 Oct 2014 12:48:52 -0500
From: Corey Minyard <cminyard@mvista.com>
MIME-Version: 1.0
References: <1412770316-5241-1-git-send-email-minyard@acm.org>
	<1412770316-5241-4-git-send-email-minyard@acm.org>
	<54365E6E.8030001@redhat.com>
In-Reply-To: <54365E6E.8030001@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to
	non-blocking connect handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, minyard@acm.org, qemu-devel@nongnu.org

On 10/09/2014 05:07 AM, Paolo Bonzini wrote:
>> +        error_setg_errno(&err, errno, "Error connecting to socket");
>> >          closesocket(s->fd);
>> >          s->fd = rc;
>> >      }
> This is missing above this hunk:
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index e6a9644..a76bb3c 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -245,6 +245,7 @@ static void wait_for_connect(void *opaque)
>      /* update rc to contain error */
>      if (!rc && val) {
>          rc = -1;
> +        errno = val;
>      }
>
>      /* connect error */
>

Yes, it is.  I see that everything went in, thanks for your work on this.

Now on to IPMI...

-corey