Re: [PATCH] bcma: Add dependency on OF_ADDRESS

[Hauke Mehrtens <hauke@hauke-m.de>]

On 10/09/2014 07:29 PM, Guenter Roeck wrote:
> On Thu, Oct 09, 2014 at 07:18:31PM +0200, Arend van Spriel wrote:
>> On 10/09/14 19:15, Arend van Spriel wrote:
>>> On 10/09/14 18:54, Rafał Miłecki wrote:
>>>> On 9 October 2014 18:41, Guenter Roeck<linux@roeck-us.net> wrote:
>>>>> Commit 2101e533f41a ("bcma: register bcma as device tree driver")
>>>>> introduces a hard dependency on OF_ADDRESS into the bcma driver.
>>>>> OF_ADDRESS is specifically disabled for the sparc architecture.
>>>>> This results in the following error when building sparc64:allmodconfig.
>>>
>>> Does this mean on sparc (using allmodconfig) you will get CONFIG_OF and
>>> !CONFIG_OF_ADDRESS? Does that makes sense?
>>
>> Is CONFIG_OF is used on sparc to access OpenBoot information?
>>
> I have no idea. All I know is that the driver doesn't build anymore with OF
> enabled and OF_ADDRESS disabled.

Device tree support in bcma is only needed on some SoC, when this is
used on a PCIe card it is not needed.

I would just deactivate the parts that are using device tree in bcma
when it is not available. I will send a patch after having something to eat.

Is there a better method which is compatible with SPARC than using
of_translate_address() to get the reg address and also take the ranges
attribute of the bus into account?

Hauke