From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Dave Airlie" <airlied@gmail.com>,
"Tiago Martins Araújo" <tiago.martins.araujo@gmail.com>
Cc: dri-devel@lists.freedesktop.org, simona@ffwll.ch
Subject: Re: DisplayID checksum validation blocking hardware capabilities - CSO T3 panel
Date: Mon, 15 Sep 2025 12:24:34 +0300 [thread overview]
Message-ID: <54375f5e6c5290aa218812c489ffe88e594217bd@intel.com> (raw)
In-Reply-To: <CAPM=9twtwNGjEXBv1Yj6vNLfEMPxuMgepOkhBKQYYtm0cmc45Q@mail.gmail.com>
On Mon, 15 Sep 2025, Dave Airlie <airlied@gmail.com> wrote:
>> Questions for Community
>> =======================
>>
>> This issue raises several questions about DisplayID validation approach:
>>
>> 1. Is this strict validation intentional for all hardware? What are the
>> security or stability reasons for treating checksum errors as fatal?
>>
>> 2. Are minor checksum variations expected in real-world panels? Is this
>> type of manufacturing variation common?
>>
>> 3. How should the kernel handle hardware with minor EDID/DisplayID issues?
>> Are there existing mechanisms for such compatibility cases?
>>
>> 4. What would be the preferred approach for handling this type of
>> compatibility issue? Are there existing precedents or guidelines?
>>
>> 5. Are other users experiencing similar DisplayID validation failures?
>> Is this an isolated case or part of a broader pattern?
>
> There is code already to ignore EDID checksum for CEA extension
> blocks, look for EDID_BLOCK_CHECKSUM, it probably could be extended to
> cover displayid blocks,
IIRC we ignore CEA extension checksum errors because hubs that
incorrectly modified the display's EDID on the fly were so common.
Anyway, this is not just about EDID extension block checksums, it's also
about DisplayID structure checksum.
I'm not sure if the attached EDID is complete, but it's looking like
just about all the checksums in it are garbage.
> Otherwise I do wonder how common this is, and whether it should be
> quirk per panel or just always do it.
I think Jon Postel was wrong, and we should never have been liberal in
accepting garbage and pretending it was valid data. But with EDIDs, that
ship has sailed, and here we are.
Considering that a valid checksum isn't exactly a guarantee of valid
EDID data inside, I'm starting to lean towards just debug logging EDID
and DisplayID checksum errors, and using whatever data we can find
inside.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-09-15 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-14 15:13 DisplayID checksum validation blocking hardware capabilities - CSO T3 panel Tiago Martins Araújo
2025-09-14 21:43 ` Dave Airlie
2025-09-15 9:24 ` Jani Nikula [this message]
2025-09-15 19:22 ` Tiago Martins Araújo
2025-10-28 19:08 ` Jani Nikula
2025-10-28 19:25 ` Tiago Martins Araújo
2025-10-28 20:09 ` Jani Nikula
2025-10-28 21:32 ` Tiago Martins Araújo
2025-10-30 10:51 ` Jani Nikula
2025-10-31 10:13 ` Jani Nikula
2025-10-31 10:42 ` Tiago Martins Araújo
2025-09-15 8:51 ` Jani Nikula
2025-09-15 9:00 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54375f5e6c5290aa218812c489ffe88e594217bd@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=tiago.martins.araujo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.