From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] serial: of-serial: fix up PM ops on no_console_suspend Date: Thu, 09 Oct 2014 22:04:51 -0700 Message-ID: <543768F3.6090703@wwwdotorg.org> References: <1412845852-26157-1-git-send-email-jingchang.lu@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:38279 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbaJJFEz (ORCPT ); Fri, 10 Oct 2014 01:04:55 -0400 In-Reply-To: <1412845852-26157-1-git-send-email-jingchang.lu@freescale.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Jingchang Lu , gregkh@linuxfoundation.org Cc: arnd@arndb.de, Joseph Lo , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 10/09/2014 02:10 AM, Jingchang Lu wrote: > Mandatorily disabling the uart clock will cause register access > hung on "no_console_suspend". This patch add condition check on > it and only disable the clock with console_suspend_enabled true. It would be useful if the email/patch subject line said "V2", and there was a changelog below. > Signed-off-by: Joseph Lo I don't think he did; he just suggested a small fix. > Signed-off-by: Jingchang Lu > --- > drivers/tty/serial/of_serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c ... From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Thu, 09 Oct 2014 22:04:51 -0700 Subject: [PATCH] serial: of-serial: fix up PM ops on no_console_suspend In-Reply-To: <1412845852-26157-1-git-send-email-jingchang.lu@freescale.com> References: <1412845852-26157-1-git-send-email-jingchang.lu@freescale.com> Message-ID: <543768F3.6090703@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/09/2014 02:10 AM, Jingchang Lu wrote: > Mandatorily disabling the uart clock will cause register access > hung on "no_console_suspend". This patch add condition check on > it and only disable the clock with console_suspend_enabled true. It would be useful if the email/patch subject line said "V2", and there was a changelog below. > Signed-off-by: Joseph Lo I don't think he did; he just suggested a small fix. > Signed-off-by: Jingchang Lu > --- > drivers/tty/serial/of_serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c ...