All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Gregory Price <gourry@gourry.net>,
	"Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com, akpm@linux-foundation.org,
	liam@infradead.org, vbabka@kernel.org, jannh@google.com,
	wangjiexun@tinylab.org, sashiko-bot <sashiko-bot@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] mm/madvise: reclaim isolated folios if PTE restart fails
Date: Wed, 16 Sep 2026 16:48:04 +0200	[thread overview]
Message-ID: <5437871c-d9ee-49d2-b24f-965c73c29c3e@kernel.org> (raw)
In-Reply-To: <aqqk89oTigJ9LS2N@gourry-fedora-PF4VCD3F>

On 9/16/26 16:42, Gregory Price wrote:
> On Wed, Sep 16, 2026 at 03:12:53PM +0100, Lorenzo Stoakes (ARM) wrote:
>>>
>>> Going to spend a little more time testing and tweaking before I post it.
>>>
>>> I've been working on a making more extensive unit tests for certain
>>> parts of mm/ and this might be a good time to look at whether I can
>>> introduce a piece of it.
>>
>> Nice, curious as to how?
>>
>> Have you tried the userland VMA tests btw? Not tooting my own horn so to
>> speak :P but it's nice, though it comes at a bit of a cost in how the files
>> have to be set up...
>>
> 
> Yes, in fact I used that as a start for exploring how I might make other
> components testable the same way.
> 
> "Stubs... stubs everywhere"
> 
> There's basically 4 testing mechanisms i explored:
> 
> 1) selftest
> 2) Usermode Linux (UML)
> 3) Userland stuff like VMA
> 4) Linux Test Project (for syscall and ABI testing)
> 
> selftests are really limited and actually create a maintenance burden,
> they're not real unit tests and are highly dependent on the actual
> machine configuration which is super annoying.
> 
> But, lets take the page allocator as an example.
> 
> The only piece of the page allocator that "should" (cough, simplifying
> here a bit) be machine specific is zone and node configurations... but
> I'm not convinced that this should require a full VM to unit-test.

I told Brendan exactly that (try stubbing it) and he tried ... and had to give
up at some point because it just wasn't feasible. ;)

-- 
Cheers,

David


  reply	other threads:[~2026-09-16 14:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 11:08 [PATCH] mm/madvise: reclaim isolated folios if PTE restart fails Gregory Price
2026-09-15  6:32 ` Andrew Morton
2026-09-15 14:13   ` Gregory Price
2026-09-15 15:55 ` Lorenzo Stoakes (ARM)
2026-09-15 17:00   ` Gregory Price
2026-09-16 13:18     ` Lorenzo Stoakes (ARM)
2026-09-16 14:02       ` Gregory Price
2026-09-16 14:08         ` Lorenzo Stoakes (ARM)
2026-09-15 17:12   ` Gregory Price
2026-09-16 13:03     ` Lorenzo Stoakes (ARM)
2026-09-16 13:57       ` Gregory Price
2026-09-16 14:12         ` Lorenzo Stoakes (ARM)
2026-09-16 14:42           ` Gregory Price
2026-09-16 14:48             ` David Hildenbrand (Arm) [this message]
2026-09-16 14:58               ` Gregory Price
2026-09-16 14:59                 ` David Hildenbrand (Arm)
2026-09-16 15:19                   ` Gregory Price
2026-09-16 15:21                     ` Lorenzo Stoakes (ARM)
2026-09-16 15:24                     ` David Hildenbrand (Arm)
2026-09-16 15:37                       ` Gregory Price
2026-09-16 15:42                         ` David Hildenbrand (Arm)
2026-09-16 16:10                           ` Gregory Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5437871c-d9ee-49d2-b24f-965c73c29c3e@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=gourry@gourry.net \
    --cc=jannh@google.com \
    --cc=kernel-team@meta.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@kernel.org \
    --cc=wangjiexun@tinylab.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.