Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

[Jacek Anaszewski <j.anaszewski@samsung.com>]

Hi,

On 10/09/2014 10:20 AM, Hans de Goede wrote:
> Hi,
>
> On 10/08/2014 03:22 PM, Jacek Anaszewski wrote:
>> Hi Hans,
>>
>> On 10/08/2014 02:42 PM, Hans de Goede wrote:
>
> <snip>
>
>>>> +    }
>>>> +
>>>> +    /* refresh device topology data after linking */
>>>> +    release_entities(mdev);
>>>> +
>>>> +    ret = get_device_topology(mdev);
>>>> +
>>>> +    /* close media device fd as it won't be longer required */
>>>> +    close(mdev->media_fd);
>>>> +
>>>> +    if (ret < 0)
>>>> +        goto err_get_dev_topology;
>>>> +
>>>> +    /* discover a pipeline for the capture device */
>>>> +    ret = discover_pipeline_by_fd(mdev, fd);
>>>> +    if (ret < 0)
>>>> +        goto err_discover_pipeline;
>>>
>>> There does not seem to be any code here to ensure that this plugin does
>>> not bind to non exonys4 fimc devices. Please fix that.
>>
>> There is. Please look above at the
>>
>> "if (!capture_entity(media_entity_name))" condition above.
>
> I already checked that, that just checks for the string "capture", which is
> way too generic, please add a more narrow guard.

While making cleanup I mistakenly removed checking for the driver name
after QUERYCAP in the beginning of plugin_init. Will fix it in the next
version.

Regards,
Jacek