From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH] drm/ttm: Don't evict BOs outside of the requested placement range Date: Fri, 10 Oct 2014 17:59:19 +0900 Message-ID: <54379FE7.8040208@daenzer.net> References: <1412834579-24703-1-git-send-email-michel@daenzer.net> <86981c0ceeb66a579fb171b453f9dba1@slartibartfast.infiniteimprobability.net> <54375092.4040203@daenzer.net> <1412931090.16185.4.camel@ukfsn.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id BF4D66E052 for ; Fri, 10 Oct 2014 01:59:27 -0700 (PDT) In-Reply-To: <1412931090.16185.4.camel@ukfsn.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alan Swanson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 10.10.2014 17:51, Alan Swanson wrote: > On Fri, 2014-10-10 at 12:20 +0900, Michel D=E4nzer wrote: >> On 09.10.2014 19:22, Alan Swanson wrote: >>> On 2014-10-09 07:02, Michel D=E4nzer wrote: >>>> From: Michel D=E4nzer >>>> >>>> The radeon driver uses placement range restrictions for several reason= s, >>>> in particular to make sure BOs in VRAM can be accessed by the CPU, e.g. >>>> during a page fault. >>>> >>>> Without this change, TTM could evict other BOs while trying to satisfy >>>> the requested placement, even if the evicted BOs were outside of the >>>> requested placement range. Doing so didn't free up any space in the >>>> requested placement range, so the (potentially high) eviction cost was >>>> incurred for no benefit. >>>> >>>> Nominating for stable because radeon driver changes in 3.17 made this >>>> much more noticeable than before. >>>> >>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D84662 >>>> Cc: stable@vger.kernel.org >>>> Signed-off-by: Michel D=E4nzer >>>> --- >>>> drivers/gpu/drm/ttm/ttm_bo.c | 20 +++++++++++++++++--- >>>> 1 file changed, 17 insertions(+), 3 deletions(-) >>>> >> [...] >> >>> I believe you need to "s/place/placement/" over this patch. >> >> The fpfn and lpfn members were moved from struct ttm_placement to a new >> struct ttm_place in f1217ed09f827e42a49ffa6a5aab672aa6f57a65. >> >> If you mean something else, please elaborate. > > This patch failed to build on 3.17.0 so wouldn't be a candidate for > stable unless the currently drm-next only ttm_place patch also goes to > stable (else replace ttm_place with ttm_placements in the patch for > stable)? Right, I guess I should drop the Cc: stable then and submit a manual = backport of it to the stable list once it has landed in Linus' tree. -- = Earthling Michel D=E4nzer | http://www.amd.com Libre software enthusiast | Mesa and X developer