From: John Crispin <blogic@openwrt.org>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH 3/4] MIPS: ralink: add support for MT7620n
Date: Fri, 10 Oct 2014 12:21:35 +0200 [thread overview]
Message-ID: <5437B32F.3060302@openwrt.org> (raw)
In-Reply-To: <5437B020.3000405@cogentembedded.com>
On 10/10/2014 12:08, Sergei Shtylyov wrote:
>> + if (bga) { name = "MT7620A"; soc_info->compatible =
>> "ralink,mt7620a-soc"; } else { - panic("mt7620: unknown
>> SoC, n0:%08x n1:%08x", n0, n1); + name = "MT7620N"; +
>> soc_info->compatible = "ralink,mt7620n-soc"; +#ifdef CONFIG_PCI
>
> I suggest:
>
> if (IS_ENABLED(CONFIG_PCI))
>
> in order to avoid this #ifdef.
>
> [...]
>
> WBR, Sergei
>
yep, holds true fo the irq-gic.c patch where i also use ifdef. I'll
fix and resend the 2 patches.
John
next prev parent reply other threads:[~2014-10-10 10:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 7:49 [PATCH 0/4] add mt7620n and mt7628an support John Crispin
2014-10-10 7:49 ` [PATCH 1/4] MIPS: ralink: cleanup early_printk John Crispin
2014-10-10 7:49 ` [PATCH 2/4] MIPS: ralink: allow loading irq registers from the devicetree John Crispin
2014-10-10 7:49 ` [PATCH 3/4] MIPS: ralink: add support for MT7620n John Crispin
2014-10-10 10:08 ` Sergei Shtylyov
2014-10-10 10:21 ` John Crispin [this message]
2014-10-10 7:49 ` [PATCH 4/4] MIPS: ralink: add mt7628an support John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437B32F.3060302@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.