From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XcYFC-0005mv-MP
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 07:20:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XcYF3-00044I-MG
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 07:20:22 -0400
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:43391)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XcYF3-00043w-DI
	for qemu-devel@nongnu.org; Fri, 10 Oct 2014 07:20:13 -0400
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Fri, 10 Oct 2014 12:20:10 +0100
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6366D1B08061
	for <qemu-devel@nongnu.org>; Fri, 10 Oct 2014 12:21:24 +0100 (BST)
Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com
	[9.149.37.216])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s9ABK8Ao11075846
	for <qemu-devel@nongnu.org>; Fri, 10 Oct 2014 11:20:08 GMT
Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s9ABK72a017563
	for <qemu-devel@nongnu.org>; Fri, 10 Oct 2014 05:20:07 -0600
Message-ID: <5437C0E6.3010104@de.ibm.com>
Date: Fri, 10 Oct 2014 13:20:06 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1412936615-18397-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1412936615-18397-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH build-fix] kvm fix compilation with GCC
	4.3.4
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

Am 10.10.2014 12:23, schrieb Paolo Bonzini:
> As usual, SLES11's GCC complained about double typedefs:

RHEL 6.5 gcc 4.4.7 complains as well. :-)

This fix helps there as well.

> 
> /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’
> /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration of ‘KVMState’ was here
> 
> Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  kvm-all.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index e98a7c7..44a5e72 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -71,7 +71,7 @@ typedef struct KVMSlot
> 
>  typedef struct kvm_dirty_log KVMDirtyLog;
> 
> -typedef struct KVMState
> +struct KVMState
>  {
>      AccelState parent_obj;
> 
> @@ -107,7 +107,7 @@ typedef struct KVMState
>      QTAILQ_HEAD(msi_hashtab, KVMMSIRoute) msi_hashtab[KVM_MSI_HASHTAB_SIZE];
>      bool direct_msi;
>  #endif
> -} KVMState;
> +};
> 
>  #define TYPE_KVM_ACCEL ACCEL_CLASS_NAME("kvm")
>