From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] Serial Flash: call spi_flash_free more coherently
Date: Fri, 10 Oct 2014 13:23:53 +0200 [thread overview]
Message-ID: <5437C1C9.5000908@keymile.com> (raw)
In-Reply-To: <52DE45DE.5050205@keymile.com>
Hello Jagannadha,
On 01/21/2014 11:03 AM, Valentin Longchamp wrote:
> On 09/17/2013 08:46 AM, Valentin Longchamp wrote:
>> Some board require spi_flash_free to be called after all the accesses,
>> in order, for instance, to restore the pin multiplexing configuration in
>> the case where the SPI pins are multiplexed.
>>
>> This patch series tries to enhance this. Patch 1 adds spi_flash_free
>> calls to env_sf so that the SPI interface is always "cleaned up" after
>> the env read/writes. Patch 2 adds a 'sf release' command that implicitly
>> calls spi_flash_free and is thus the pendant of 'sf probe'. Patch 3 uses
>> the 'sf command' for the km_arm board scripts.
>>
>>
>> Valentin Longchamp (3):
>> env_sf: generalize call to spi_flash_free after accesses
>> cmd_sf: add 'release' command
>> km_arm: call 'sf release' in the newenv and update scripts
>>
>> common/cmd_sf.c | 13 ++++++++++++-
>> common/env_sf.c | 34 ++++++++++++++++------------------
>> include/configs/km/km_arm.h | 6 ++++--
>> 3 files changed, 32 insertions(+), 21 deletions(-)
>>
>
> I have sent this series 4 months ago and while it is according to patchwork
> under review I have not received any feedback yet.
>
> That would be nice if this goes into the next merge window since they have been
> floating around for 4 months now.
>
Here I ping again ! I have sent this series more than a year ago and you had
promised me a off list a review "in a few days" at the beginning of march 2014
... but I have seen nothing. The only thing that has happened is that the first
patch of the series was rejected by you.
I don't mind that the patch was rejected. But this is a required patch for us
and I want it to be mainlined, because I have to rebase it internally for every
release. Without the feedback about why it was rejected, I cannot however
improve it and resubmit it.
Can you please review this series and give me a feedback about it ?
Valentin
next prev parent reply other threads:[~2014-10-10 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 6:46 [U-Boot] [PATCH 0/3] Serial Flash: call spi_flash_free more coherently Valentin Longchamp
2013-09-17 6:46 ` [U-Boot] [PATCH 1/3] env_sf: generalize call to spi_flash_free after accesses Valentin Longchamp
2013-09-17 6:46 ` [U-Boot] [PATCH 2/3] cmd_sf: add 'release' command Valentin Longchamp
2013-09-17 6:46 ` [U-Boot] [PATCH 3/3] km_arm: call 'sf release' in the newenv and update scripts Valentin Longchamp
2014-01-21 10:03 ` [U-Boot] [PATCH 0/3] Serial Flash: call spi_flash_free more coherently Valentin Longchamp
2014-10-10 11:23 ` Valentin Longchamp [this message]
2014-10-15 7:26 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437C1C9.5000908@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.