From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction
Date: Fri, 10 Oct 2014 10:13:56 -0600 [thread overview]
Message-ID: <543805C4.50204@redhat.com> (raw)
In-Reply-To: <1410411902-7104-3-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On 09/10/2014 11:05 PM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> blockdev.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> qapi-schema.json | 3 +++
> 2 files changed, 51 insertions(+)
>
> +++ b/qapi-schema.json
> @@ -1251,11 +1251,14 @@
> #
> # A discriminated record of operations that can be performed with
> # @transaction.
> +#
> +# Since 1.1, blockdev-backup since 2.1
If we're going to do this, we should be accurate. s/2.1/2.2. Furthermore:
drive-backup and abort were added in 1.6
blockdev-snapshot-internal-sync was added in 1.7
(but yes, I'm glad that you are wanting to add version information).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-10 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 5:04 [Qemu-devel] [PATCH 0/3] qmp: Add "blockdev-backup" Fam Zheng
2014-09-11 5:05 ` [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup' Fam Zheng
2014-10-10 11:43 ` Markus Armbruster
2014-10-31 9:01 ` Kevin Wolf
2014-11-03 1:46 ` Fam Zheng
2014-11-03 14:32 ` Kevin Wolf
2014-11-04 1:59 ` Fam Zheng
2014-11-04 6:47 ` Markus Armbruster
2014-11-04 7:18 ` Fam Zheng
2014-12-02 19:07 ` Markus Armbruster
2014-09-11 5:05 ` [Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction Fam Zheng
2014-10-10 11:46 ` Markus Armbruster
2014-10-10 16:13 ` Eric Blake [this message]
2014-09-11 5:05 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
2014-10-10 12:07 ` Markus Armbruster
2014-10-31 4:30 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543805C4.50204@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.