From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] arm32: fix build after 063188f4b3
Date: Fri, 10 Oct 2014 17:35:15 +0100
Message-ID: <54380AC3.6010902@linaro.org>
References: <54380211020000780003DC42@mail.emea.novell.com>
	<5437E94E.9010202@linaro.org>
	<54380E91020000780003DD61@mail.emea.novell.com>
	<5438018D.1000308@linaro.org>
	<543822E2020000780003DEE1@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1XcdA7-0005iG-QG
	for xen-devel@lists.xenproject.org; Fri, 10 Oct 2014 16:35:27 +0000
Received: by mail-wg0-f51.google.com with SMTP id b13so4294718wgh.10
	for <xen-devel@lists.xenproject.org>;
	Fri, 10 Oct 2014 09:35:24 -0700 (PDT)
In-Reply-To: <543822E2020000780003DEE1@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Suriyan Ramasami <suriyan.r@gmail.com>, Tim Deegan <tim@xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org



On 10/10/2014 17:18, Jan Beulich wrote:
>>>> On 10.10.14 at 17:55, <julien.grall@linaro.org> wrote:
>> On 10/10/2014 15:51, Jan Beulich wrote:
>>>>>> On 10.10.14 at 16:12, <julien.grall@linaro.org> wrote:
>>>> This function is duplicate in 3 different places in Xen:
>>>> 	- arch/arm/psci.c
>>>> 	- arch/platforms/exynos5.c
>>>> 	- arch/platforms/seattle.c
>>>>
>>>> So all those functions should be fixed. I think it's time to introduce a
>>>> global SMC function...
>>>
>>> Okay, I got the build failure only in this one place. But if and when
>>> the compiler choses to do such transformations is entirely up to it,
>>> so yes, if there are multiple instances likely they all would need
>>> fixing.
>>
>> BTW,  named register is a GNU extension and not supported by clang. Can
>> you avoid to use them? Maybe by writing the function in assembly. So we
>> are safe against any compiler optimization.
>
> I don't think I'm the right one to write ARM assembly code at this
> point. I really just want the build fixed - anything beyond that I'd
> rather leave to you guys.

I will write a patch and send it during the week-end.

Regards,

-- 
Julien Grall