All of lore.kernel.org
 help / color / mirror / Atom feed
From: wenzong fan <wenzong.fan@windriver.com>
To: "Peter A. Bigot" <pab@pabigot.com>,
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH 0/1][meta-networking] ntp: fix path to driftfile
Date: Sat, 11 Oct 2014 17:19:38 +0800	[thread overview]
Message-ID: <5438F62A.8060601@windriver.com> (raw)
In-Reply-To: <5437BF2B.9060909@pabigot.com>

On 10/10/2014 07:12 PM, Peter A. Bigot wrote:
> On 10/09/2014 10:22 PM, wenzong.fan@windriver.com wrote:
>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>
>> Default path to driftfile is "/etc/ntp.drift", that doesn't work since
>> ntp daemon is always started with "ntp" user. It should be created at
>> the home directory of "ntp" which is "/var/lib/ntp/".
>
> Could you provide a bit more detail on why this "doesn't work"? Does it
> violate the FHS, or complicate securing an image, or...?
>
> I see that Debian apparently puts the file in /var/lib/ntp.
>
> I certainly don't object to the change, but "doesn't work" suggests this
> patch fixes a functional bug, not an inconsistency with policy.  More
> detail in the commit message will help us occasional contributors
> understand how things are supposed to be done and why.

Sorry for the confusions, the "doesn't work" means ntp user can't create 
driftfile under "/etc".

The fix refer to other distributions, just move driftfile to "/var/lib/ntp".

Thanks
Wenzong

>
> Thanks.
>
> Peter
>
>>
>> The following changes since commit
>> 17ff23b4a4a0e5ed7efde107fb00296f1ebd5fdd:
>>
>>    xf86-video-geode: fix build with new glibc-2.20 (2014-10-06
>> 01:07:53 +0200)
>>
>> are available in the git repository at:
>>
>>    git://git.pokylinux.org/poky-contrib wenzong/ntp
>>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/ntp
>>
>> Wenzong Fan (1):
>>    ntp: fix path to driftfile
>>
>>   meta-networking/recipes-support/ntp/ntp.inc |   15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>
>


  reply	other threads:[~2014-10-11  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  3:22 [PATCH 0/1][meta-networking] ntp: fix path to driftfile wenzong.fan
2014-10-10  3:22 ` [PATCH 1/1][meta-networking] " wenzong.fan
2014-10-10 11:12 ` [PATCH 0/1][meta-networking] " Peter A. Bigot
2014-10-11  9:19   ` wenzong fan [this message]
2014-10-10 11:21 ` Peter A. Bigot
2014-10-11  9:55   ` wenzong fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5438F62A.8060601@windriver.com \
    --to=wenzong.fan@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=pab@pabigot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.