From: Peter Hurley <peter@hurleysoftware.com>
To: Mikael Pettersson <mikpelinux@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Rabin Vincent <rabin@rab.in>
Subject: Re: [PATCH] arm: Blacklist gcc 4.8.[012] and 4.9.0 with CONFIG_FRAME_POINTER
Date: Sat, 11 Oct 2014 14:04:47 -0400 [thread overview]
Message-ID: <5439713F.1050007@hurleysoftware.com> (raw)
In-Reply-To: <21561.23527.405747.338285@gargle.gargle.HOWL>
On 10/11/2014 12:33 PM, Mikael Pettersson wrote:
> Peter Hurley writes:
> > On 10/10/2014 12:36 PM, Russell King - ARM Linux wrote:
> > > On Fri, Oct 10, 2014 at 12:26:14PM -0400, Peter Hurley wrote:
> > >> gcc versions 4.8.[012] and 4.9.0 generates code that prematurely
> > >> adjusts the stack pointer such that still-to-be-referenced locals
> > >> are below the stack pointer, which allows them to be overwritten
> > >> by interrupts.
> > >
> > > I would much rather do this in asm-offsets.c, along side the other ARM
> > > specific buggy compiler test(s). I'm presently putting together such
> > > a patch.
> > >
> > > The information in the thread on linux-omap says only GCC 4.8.1 and
> > > GCC 4.8.2. Where do you get the other versions from?
> >
> > The gcc PR linked in the commit message; see the "Known to fail" field.
>
> The 4.8.0 release is broken, but the 4.9.0 one is not. It's unfortunate,
> but "4.9.0" may refer to "the 4.9.0 release" or to "some point after trunk
> forked 4.8 branch up to and including the 4.9.0 release point". In this
> case, it's the latter -- this can be inferred from the fact that the
> fix went into trunk in October 2013 while 4.9.0 was branched and released
> during the first half of 2014.
Is there a reasonably quick way to determine if a particular commit is
in a particular release of gcc?
Starting from the mainline viewcvs revision page for this fix here,
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=204203
(which is the link from the PR for the fix), navigation to anywhere
else in the gcc tree is impossible. I can't even look at the Changelog.
Same with the backport.
Inferring by date seems error-prone.
Regards,
Peter Hurley
next prev parent reply other threads:[~2014-10-11 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 16:26 [PATCH] arm: Blacklist gcc 4.8.[012] and 4.9.0 with CONFIG_FRAME_POINTER Peter Hurley
2014-10-10 16:36 ` Russell King - ARM Linux
2014-10-10 16:55 ` Peter Hurley
2014-10-11 16:33 ` Mikael Pettersson
2014-10-11 18:04 ` Peter Hurley [this message]
2014-10-12 9:50 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5439713F.1050007@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mikpelinux@gmail.com \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.