From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 2/5] KVM: x86: Emulator performs code segment checks on read access Date: Sun, 12 Oct 2014 14:12:50 +0200 Message-ID: <543A7042.2050507@redhat.com> References: <20141006203238.GA4989@potion.brq.redhat.com> <1412906870-4322-1-git-send-email-namit@cs.technion.ac.il> <20141010155455.GA17902@potion.brq.redhat.com> <5438FAD6.3010805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Nadav Amit , kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mail-wg0-f50.google.com ([74.125.82.50]:53616 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbaJLMM7 (ORCPT ); Sun, 12 Oct 2014 08:12:59 -0400 Received: by mail-wg0-f50.google.com with SMTP id a1so6721959wgh.21 for ; Sun, 12 Oct 2014 05:12:58 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 12/10/2014 08:57, Nadav Amit ha scritto: > Looks good. I=E2=80=99ll give it a try but it is hard to give a defin= itive=20 > answer, since the emulator is still bug-ridden. Yes, we need to write unit tests for this, especially the conforming case. A bit of a pain to get kvm-unit-tests in ring 3 (access.flat does it), but I'll give it a shot. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUOnBCAAoJEBRUblpOawnXLHEH/3zlIsVFow9IWrZsxaZopWy5 DKncQriHnhsyc6W2U9oFvNgB/7+dTWscdR58jnKLr/Qt64DGH01pq4MvisdhV+31 53pv+CycUgs85EoZkA7MzArbT1Tb/gd/KB8QoqdKIC4+bNEd6JMydcsq5d6nMgOd yWLYjcYzWzzmJSNCC7UYOtN4SB4brC5RyITLq+CgT4ufSPHtBYxGd8fSHpzvJzTU T1hqelYcLRFGzoPR4ux4SP8EgXle+sslFV4KAyXkucLIafmeekcmR/AO8hy84TXj Kcpt6Y3hsY8pWXM3YB4LF/7+NuaPu/Ud+2VkbfuFhq5gUtVLwjtWtA32IlYdFEc=3D =3DBhUU -----END PGP SIGNATURE-----