Re: [PATCH RFC 3/5] sched,numa: preparations for complex topology placement

[Rik van Riel <riel@redhat.com>]

On 10/12/2014 10:37 AM, Peter Zijlstra wrote:
> On Wed, Oct 08, 2014 at 03:37:28PM -0400, riel@redhat.com wrote:
>> From: Rik van Riel <riel@redhat.com>
>>
>> Preparatory patch for adding NUMA placement on systems with
>> complex NUMA topology. Also fix a potential divide by zero
>> in group_weight()
>>
>> Signed-off-by: Rik van Riel <riel@redhat.com>
>> ---
>>   include/linux/topology.h |  1 +
>>   kernel/sched/core.c      |  2 +-
>>   kernel/sched/fair.c      | 57 +++++++++++++++++++++++++++++++-----------------
>>   3 files changed, 39 insertions(+), 21 deletions(-)
>>
>> diff --git a/include/linux/topology.h b/include/linux/topology.h
>> index bf40d46..f8dfad9 100644
>> --- a/include/linux/topology.h
>> +++ b/include/linux/topology.h
>> @@ -47,6 +47,7 @@
>>   		if (nr_cpus_node(node))
>>
>>   int arch_update_cpu_topology(void);
>> +extern int sched_domains_numa_levels;
>>   extern int node_hops(int i, int j);
>>
>
> I'm not sure we want to share this globally, please consider using
> kernel/sched/sched.h
>
Good point. I will do that.