From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@infradead.org>,
"Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: "James Bottomley (jbottomley@parallels.com)"
<jbottomley@parallels.com>,
"dgilbert@interlog.com" <dgilbert@interlog.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Don Brace (PMC)" <Don.Brace@pmcs.com>,
"Scales, Webb" <webb.scales@hp.com>
Subject: Re: Concurrent SG_SCSI_RESET ioctls
Date: Mon, 13 Oct 2014 11:15:19 +0200 [thread overview]
Message-ID: <543B9827.2060305@acm.org> (raw)
In-Reply-To: <20141011161110.GA16812@infradead.org>
On 10/11/14 18:11, Christoph Hellwig wrote:
> Hi Robert,
>
> can you take a look at the patches at:
>
> http://git.infradead.org/users/hch/scsi.git/shortlog/refs/heads/scsi-ioctl
>
> and confirm if they fix your issue?
Hello Christoph,
At least to me patches 1/4..3/4 look like nice cleanup patches.
Regarding patch 4/4: I'm not sure yet what's the best way for addressing
potentially concurrent SG_SCSI_RESET ioctl calls. As far as I know many
SCSI LLDs have been implemented assuming that eh_*_reset_handler() calls
are serialized per SCSI host. Does this mean that a mutex has to be
added to avoid that an eh_*_reset_handler() call can be triggered via an
ioctl while at the same time the SCSI error handler thread is invoking
one of the eh_*_reset_handler() callback functions due to SCSI error
handling ?
For a prior discussion of this topic, see also
http://thread.gmane.org/gmane.linux.scsi/82582/focus=82747.
Bart.
next prev parent reply other threads:[~2014-10-13 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 23:32 Concurrent SG_SCSI_RESET ioctls Elliott, Robert (Server Storage)
2014-10-11 11:05 ` Christoph Hellwig
2014-10-11 16:11 ` Christoph Hellwig
2014-10-11 22:06 ` Elliott, Robert (Server Storage)
2014-10-14 11:13 ` Christoph Hellwig
2014-10-14 16:42 ` Douglas Gilbert
2014-10-15 13:25 ` Christoph Hellwig
2014-10-15 14:34 ` Elliott, Robert (Server Storage)
2014-10-24 14:51 ` Christoph Hellwig
2014-10-24 16:29 ` Douglas Gilbert
2014-10-11 23:04 ` Elliott, Robert (Server Storage)
2014-10-13 9:15 ` Bart Van Assche [this message]
2014-10-13 10:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543B9827.2060305@acm.org \
--to=bvanassche@acm.org \
--cc=Don.Brace@pmcs.com \
--cc=Elliott@hp.com \
--cc=dgilbert@interlog.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=webb.scales@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.