From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] move XENMEM_get_vnumainfo out of tools-only section of public/memory.h Date: Mon, 13 Oct 2014 11:14:55 +0100 Message-ID: <543BA61F.8010206@citrix.com> References: <5438031A020000780003DC67@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3075064658227018174==" Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xdcec-0001Ad-75 for xen-devel@lists.xenproject.org; Mon, 13 Oct 2014 10:15:02 +0000 In-Reply-To: <5438031A020000780003DC67@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Ian Campbell , Ian Jackson , Keir Fraser , ufimtseva@gmail.com, Tim Deegan List-Id: xen-devel@lists.xenproject.org --===============3075064658227018174== Content-Type: multipart/alternative; boundary="------------050707080405010408020306" --------------050707080405010408020306 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 10/10/14 15:02, Jan Beulich wrote: > After all this interface specifically exists for guest kernels to learn > about their (virtual) topology. I'm sure I made a comment to this > effect during review, but apparently I then didn't notice that this > never got carried out. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -521,6 +521,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_ > * The zero value is appropiate. > */ > > +#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */ > + > +/* > + * XENMEM_get_vnumainfo used by guest to get > + * vNUMA topology from hypervisor. > + */ > +#define XENMEM_get_vnumainfo 26 > + > /* vNUMA node memory ranges */ > struct vmemrange { > uint64_t start, end; > @@ -565,14 +573,6 @@ struct vnuma_topology_info { > typedef struct vnuma_topology_info vnuma_topology_info_t; > DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t); > > -/* > - * XENMEM_get_vnumainfo used by guest to get > - * vNUMA topology from hypervisor. > - */ > -#define XENMEM_get_vnumainfo 26 > - > -#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */ > - > /* Next available subop number is 27 */ > > #endif /* __XEN_PUBLIC_MEMORY_H__ */ > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------050707080405010408020306 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 10/10/14 15:02, Jan Beulich wrote:
After all this interface specifically exists for guest kernels to learn
about their (virtual) topology. I'm sure I made a comment to this
effect during review, but apparently I then didn't notice that this
never got carried out.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -521,6 +521,14 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_
  * The zero value is appropiate.
  */
 
+#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
+
+/*
+ * XENMEM_get_vnumainfo used by guest to get
+ * vNUMA topology from hypervisor.
+ */
+#define XENMEM_get_vnumainfo                26
+
 /* vNUMA node memory ranges */
 struct vmemrange {
     uint64_t start, end;
@@ -565,14 +573,6 @@ struct vnuma_topology_info {
 typedef struct vnuma_topology_info vnuma_topology_info_t;
 DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);
 
-/*
- * XENMEM_get_vnumainfo used by guest to get
- * vNUMA topology from hypervisor.
- */
-#define XENMEM_get_vnumainfo               26
-
-#endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
-
 /* Next available subop number is 27 */
 
 #endif /* __XEN_PUBLIC_MEMORY_H__ */






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------050707080405010408020306-- --===============3075064658227018174== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3075064658227018174==--