Re: [WIP PATCH] Scarlett mixer interface for 6i6, 18i6, 18i8 and 18i20.

[David Henningsson <david.henningsson@canonical.com>]

On 2014-10-09 10:31, Daniel Mack wrote:
> Hi Tobias,
>
> On 10/09/2014 12:49 AM, Tobias Hoffmann wrote:
>> And some more comments from me:
>>
>> On 08/10/14 21:04, Daniel Mack wrote:
>>> +
>>> +/* #define WITH_METER */
>>> +/* #define WITH_LOGSCALEMETER */
>>> These should either be converted to module parameters, or removed
>>> alltogether. Why are they configurable, anyway?
>> As I've said in my earlier mail, code is current not working: Metering
>> should be removed from this patch (or rewritten to use hwdep-API).
>>
>>>> +#define LEVEL_BIAS 128  /* some gui mixers can't handle negative ctl values (alsamixergui, qasmixer, ...) */
>>>> +
>>>> +#ifndef LEVEL_BIAS
>>>> +	#define LEVEL_BIAS 0
>>>> +#endif
>>> Same here.
>> As LEVEL_BIAS = 0 definitely causes problems with some mixer GUIs, the
>> #ifndef ... #endif should be removed completely.
> Alright. David, will you be working on new version of the patch?

Yes, time permitting.

Thanks for the comments - so far they have mostly been about polishing 
and cleanup, and that's not too difficult, if that's all that's needed. 
But at this point, it would be nice if the maintainer(s) took a 
birds-eye view of this driver and looked at the over all structure. I e, 
so I don't spend time polishing things, that would anyway need a big 
rewrite before they are accepted.

// David