From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xdfth-00015z-CR for qemu-devel@nongnu.org; Mon, 13 Oct 2014 09:42:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xdftb-00081g-S5 for qemu-devel@nongnu.org; Mon, 13 Oct 2014 09:42:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35872 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xdftb-00081C-HA for qemu-devel@nongnu.org; Mon, 13 Oct 2014 09:42:43 -0400 Message-ID: <543BD657.4070104@suse.de> Date: Mon, 13 Oct 2014 15:40:39 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1412663604-7924-1-git-send-email-arei.gonglei@huawei.com> <543467B9.9030306@redhat.com> <543515CA.3030308@huawei.com> <543BAF8F.9010009@huawei.com> In-Reply-To: <543BAF8F.9010009@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 0/5] add description field in ObjectProperty and PropertyInfo struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei , Gonglei Cc: "Huangweidong (C)" , "mst@redhat.com" , Luonengjun , "qemu-devel@nongnu.org" , "armbru@redhat.com" , 'Paolo Bonzini' , "Huangpeng (Peter)" , "lcapitulino@redhat.com" Am 13.10.2014 um 12:55 schrieb Gonglei: > On 2014/10/9 19:51, Gonglei wrote: >=20 >> Andreas, ping? >> >=20 >=20 > Ping..., again. Already queued, not yet pushed. On my way to KVM Forum... Regards, Andreas >=20 >> Best regards, >> -Gonglei >> >>> -----Original Message----- >>> From: qemu-devel-bounces+arei.gonglei=3Dhotmail.com@nongnu.org >>> [mailto:qemu-devel-bounces+arei.gonglei=3Dhotmail.com@nongnu.org] On >>> Behalf Of Gonglei >>> Sent: Wednesday, October 08, 2014 6:46 PM >>> To: Paolo Bonzini >>> Cc: Huangweidong (C); mst@redhat.com; Luonengjun; armbru@redhat.com; >>> qemu-devel@nongnu.org; Huangpeng (Peter); lcapitulino@redhat.com; >>> afaerber@suse.de >>> Subject: Re: [Qemu-devel] [PATCH v5 0/5] add description field in >>> ObjectProperty and PropertyInfo struct >>> >>> On 2014/10/8 6:22, Paolo Bonzini wrote: >>> >>>> Il 07/10/2014 08:33, arei.gonglei@huawei.com ha scritto: >>>>> From: Gonglei >>>>> >>>>> v5 -> v4: >>>>> 1. add some improvements by Michael's suggtion, Thanks. (Michael) >>>>> 2. add 'Reviewed-by' tag (Paolo, Michael, Eric) >>>> >>>> Andreas, this series depends on patches in qom-next so you'll have t= o >>>> take it. >>>> >>> >>> Yes, please. Thanks! >>> >>> Best regards, >>> -Gonglei >>> >>>> Thanks, >>>> >>>> Paolo >>>> >>>>> v4 -> v3: >>>>> 1. rebase on qom-next tree (Andreas) >>>>> 2. fix memory leak in PATCH 2, move object_property_set_descriptio= n >>> calling >>>>> in object_property_add_alias() from PATCH 3 to PATCH 2. (Paolo) >>>>> 3. drop "?:" in PATCH 2, call g_strdup() directly >>>>> 4. rework PATCH 4, change description as optional field, >>>>> drop "?:" conditional express (Eric) >>>>> >>>>> v3 -> v2: >>>>> 1. add a new "description" field to DevicePropertyInfo, and format >>>>> it in qdev_device_help() in PATCH 6 (Paolo) >>>>> >>>>> v2 -> v1: >>>>> 1. rename "fail" label to "out" in PATCH 1 (Andreas) >>>>> 2. improve descriptions in PATCH 3 (Paolo, adding Signed-off-by Pa= olo in >>> this patch) >>>>> 3. rework PATCH 5, set description at qdev_property_add_static(), >>>>> then copy the description of target_obj.property. (Paolo) >>>>> 4. free description filed of ObjectProperty avoid memory leak in P= ATCH 4. >>>>> >>>>> This patch series based on qom-next tree: >>>>> https://github.com/afaerber/qemu-cpu/commits/qom-next >>>>> >>>>> Add a description field in both ObjectProperty and PropertyInfo str= uct. >>>>> The descriptions can serve as documentation in the code, >>>>> and they can be used to provide better help. For example: >>>>> >>>>> Before this patch series: >>>>> >>>>> $./qemu-system-x86_64 -device virtio-blk-pci,? >>>>> >>>>> virtio-blk-pci.iothread=3Dlink >>>>> virtio-blk-pci.x-data-plane=3Dbool >>>>> virtio-blk-pci.scsi=3Dbool >>>>> virtio-blk-pci.config-wce=3Dbool >>>>> virtio-blk-pci.serial=3Dstr >>>>> virtio-blk-pci.secs=3Duint32 >>>>> virtio-blk-pci.heads=3Duint32 >>>>> virtio-blk-pci.cyls=3Duint32 >>>>> virtio-blk-pci.discard_granularity=3Duint32 >>>>> virtio-blk-pci.bootindex=3Dint32 >>>>> virtio-blk-pci.opt_io_size=3Duint32 >>>>> virtio-blk-pci.min_io_size=3Duint16 >>>>> virtio-blk-pci.physical_block_size=3Duint16 >>>>> virtio-blk-pci.logical_block_size=3Duint16 >>>>> virtio-blk-pci.drive=3Dstr >>>>> virtio-blk-pci.virtio-backend=3Dchild >>>>> virtio-blk-pci.command_serr_enable=3Don/off >>>>> virtio-blk-pci.multifunction=3Don/off >>>>> virtio-blk-pci.rombar=3Duint32 >>>>> virtio-blk-pci.romfile=3Dstr >>>>> virtio-blk-pci.addr=3Dpci-devfn >>>>> virtio-blk-pci.event_idx=3Don/off >>>>> virtio-blk-pci.indirect_desc=3Don/off >>>>> virtio-blk-pci.vectors=3Duint32 >>>>> virtio-blk-pci.ioeventfd=3Don/off >>>>> virtio-blk-pci.class=3Duint32 >>>>> >>>>> After: >>>>> >>>>> $./qemu-system-x86_64 -device virtio-blk-pci,? >>>>> >>>>> virtio-blk-pci.iothread=3Dlink >>>>> virtio-blk-pci.x-data-plane=3Dbool (on/off) >>>>> virtio-blk-pci.scsi=3Dbool (on/off) >>>>> virtio-blk-pci.config-wce=3Dbool (on/off) >>>>> virtio-blk-pci.serial=3Dstr >>>>> virtio-blk-pci.secs=3Duint32 >>>>> virtio-blk-pci.heads=3Duint32 >>>>> virtio-blk-pci.cyls=3Duint32 >>>>> virtio-blk-pci.discard_granularity=3Duint32 >>>>> virtio-blk-pci.bootindex=3Dint32 >>>>> virtio-blk-pci.opt_io_size=3Duint32 >>>>> virtio-blk-pci.min_io_size=3Duint16 >>>>> virtio-blk-pci.physical_block_size=3Duint16 (A power of two between= 512 and >>> 32768) >>>>> virtio-blk-pci.logical_block_size=3Duint16 (A power of two between = 512 and >>> 32768) >>>>> virtio-blk-pci.drive=3Dstr (ID of a drive to use as a backend) >>>>> virtio-blk-pci.virtio-backend=3Dchild >>>>> virtio-blk-pci.command_serr_enable=3Dbool (on/off) >>>>> virtio-blk-pci.multifunction=3Dbool (on/off) >>>>> virtio-blk-pci.rombar=3Duint32 >>>>> virtio-blk-pci.romfile=3Dstr >>>>> virtio-blk-pci.addr=3Dint32 (Slot and optional function number, exa= mple: 06.0 >>> or 06) >>>>> virtio-blk-pci.event_idx=3Dbool (on/off) >>>>> virtio-blk-pci.indirect_desc=3Dbool (on/off) >>>>> virtio-blk-pci.vectors=3Duint32 >>>>> virtio-blk-pci.ioeventfd=3Dbool (on/off) >>>>> virtio-blk-pci.class=3Duint32 >>>>> >>>>> >>>>> Gonglei (5): >>>>> qdev: add description field in PropertyInfo struct >>>>> qom: add description field in ObjectProperty struct >>>>> qdev: set the object property's description to the qdev property'= s. >>>>> qmp: print descriptions of object properties >>>>> qdev: drop legacy_name from qdev properties >>>>> >>>>> hw/core/qdev-properties-system.c | 8 ++++---- >>>>> hw/core/qdev-properties.c | 14 ++++++++------ >>>>> hw/core/qdev.c | 5 +++++ >>>>> include/hw/qdev-core.h | 2 +- >>>>> include/qom/object.h | 14 ++++++++++++++ >>>>> qapi-schema.json | 4 +++- >>>>> qdev-monitor.c | 7 ++++++- >>>>> qmp.c | 13 ++++++++++--- >>>>> qom/object.c | 20 ++++++++++++++++++++ >>>>> target-ppc/translate_init.c | 2 +- >>>>> 10 files changed, 72 insertions(+), 17 deletions(-) >>>>> >>>> >>> >>> >>> >> >> >=20 >=20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg