From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 04/15] drm/panel: s6e8aa0: Use standard MIPI DSI function Date: Mon, 13 Oct 2014 16:13:16 +0200 Message-ID: <543BDDFC.2090500@samsung.com> References: <1413195395-3355-1-git-send-email-thierry.reding@gmail.com> <1413195395-3355-4-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id 328DF89F61 for ; Mon, 13 Oct 2014 07:13:21 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NDD0089JZMTQ360@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 13 Oct 2014 15:16:05 +0100 (BST) In-reply-to: <1413195395-3355-4-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 10/13/2014 12:16 PM, Thierry Reding wrote: > From: Thierry Reding > > Use the newly introduced mipi_dsi_set_maximum_return_packet_size() > function to replace an open-coded version. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/panel/panel-s6e8aa0.c | 16 ++-------------- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c > index 0f85a7c37687..c31e2953f290 100644 > --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c > +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c > @@ -800,27 +800,15 @@ static void s6e8aa0_panel_init(struct s6e8aa0 *ctx) > } > > static void s6e8aa0_set_maximum_return_packet_size(struct s6e8aa0 *ctx, > - int size) > + u16 size) I guess this whole function should be removed and direct call to mipi_dsi_set_maximum_return_packet_size should be used. Regards Andrzej > { > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - const struct mipi_dsi_host_ops *ops = dsi->host->ops; > - u8 buf[] = {size, 0}; > - struct mipi_dsi_msg msg = { > - .channel = dsi->channel, > - .type = MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE, > - .tx_len = sizeof(buf), > - .tx_buf = buf > - }; > int ret; > > if (ctx->error < 0) > return; > > - if (!ops || !ops->transfer) > - ret = -EIO; > - else > - ret = ops->transfer(dsi->host, &msg); > - > + ret = mipi_dsi_set_maximum_return_packet_size(dsi, size); > if (ret < 0) { > dev_err(ctx->dev, > "error %d setting maximum return packet size to %d\n", >