From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-xen-4.5 v3 03/16] x86/boot/reloc: Create
 generic alloc and copy functions
Date: Mon, 13 Oct 2014 16:02:28 +0100
Message-ID: <543BE984.2080203@citrix.com>
References: <1412790736-28915-1-git-send-email-daniel.kiper@oracle.com>
	<1412790736-28915-4-git-send-email-daniel.kiper@oracle.com>
	<54365924.2060403@citrix.com>
	<20141013150018.GD3460@olila.local.net-space.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Xdh93-00050p-1Z
	for xen-devel@lists.xenproject.org; Mon, 13 Oct 2014 15:02:45 +0000
In-Reply-To: <20141013150018.GD3460@olila.local.net-space.pl>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: jgross@suse.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ross.philipson@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, jbeulich@suse.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org
List-Id: xen-devel@lists.xenproject.org

On 13/10/14 16:00, Daniel Kiper wrote:
> On Thu, Oct 09, 2014 at 10:45:08AM +0100, Andrew Cooper wrote:
>> On 08/10/14 18:52, Daniel Kiper wrote:
>>> Create generic alloc and copy functions. We need them to
>>> introduce MBD struct and multiboot2 protocol. Please
>>> check later patches for more details.
>>>
>>> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
>> copy_string() is fine, as all its uses are in terms of u32s, but why do
>> the other two change from pointers to u32s now?
>>
>> You could drop almost all of the casts with the reintroduction of the
>> void pointers.  This code, after all, is only ever going to be 32bit.
> We need some casts in this patch but after moving to MBD there are not any casts.
>
> Daniel

Ok - that is a good reason.

~Andrew