From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 for 4.5] arm32: fix build after 063188f4b3 Date: Mon, 13 Oct 2014 16:39:56 +0100 Message-ID: <543BF24C.40204@linaro.org> References: <1413214141-370-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XdhjB-0007nw-5v for xen-devel@lists.xenproject.org; Mon, 13 Oct 2014 15:40:05 +0000 Received: by mail-wg0-f49.google.com with SMTP id x12so9098040wgg.32 for ; Mon, 13 Oct 2014 08:40:03 -0700 (PDT) In-Reply-To: <1413214141-370-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com, Jan Beulich List-Id: xen-devel@lists.xenproject.org On 10/13/2014 04:29 PM, Julien Grall wrote: > "xen: arm: Add support for the Exynos secure firmware" introduced code > assuming that exynos_smc() would get called with arguments in certain > registers. While the "noinline" attribute guarantees the function to > not get inlined, it does not guarantee that all arguments arrive in the > assumed registers: gcc's interprocedural analysis can result in clone > functions to be created where some of the incoming arguments (commonly > when they have constant values) get replaced by putting in place the > respective values inside the clone. > > Xen contains in multiple place of this SMC function: consolidate the function > in a single place and write it in assembly. > > Signed-off-by: Julien Grall > Signed-off-by: Jan Beulich > > --- > This is a fix for Xen 4.5 to compile the hypervisor with GCC 4.9.1, used by > Fedora & co. > > Jan: I kept your Signed-off-by for the commit message. > > Changes in v2: > - Write the SMC call in assembly > - Consolidate the code in a single place I forgot to add that this patch has been build tested on both arm32 and arm64 and successfully boot on both midway and the Foundation Model. Regards, -- Julien Grall