From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 for 4.5] arm32: fix build after 063188f4b3 Date: Mon, 13 Oct 2014 17:05:09 +0100 Message-ID: <543BF835.8060906@linaro.org> References: <1413214141-370-1-git-send-email-julien.grall@linaro.org> <543C108E020000780003E678@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xdi7Z-00014x-VO for xen-devel@lists.xenproject.org; Mon, 13 Oct 2014 16:05:18 +0000 Received: by mail-wi0-f181.google.com with SMTP id hi2so7882659wib.2 for ; Mon, 13 Oct 2014 09:05:16 -0700 (PDT) In-Reply-To: <543C108E020000780003E678@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Jan, On 10/13/2014 04:49 PM, Jan Beulich wrote: >>>> On 13.10.14 at 17:29, wrote: >> "xen: arm: Add support for the Exynos secure firmware" introduced code >> assuming that exynos_smc() would get called with arguments in certain >> registers. While the "noinline" attribute guarantees the function to >> not get inlined, it does not guarantee that all arguments arrive in the >> assumed registers: gcc's interprocedural analysis can result in clone >> functions to be created where some of the incoming arguments (commonly >> when they have constant values) get replaced by putting in place the >> respective values inside the clone. >> >> Xen contains in multiple place of this SMC function: consolidate the >> function >> in a single place and write it in assembly. >> >> Signed-off-by: Julien Grall >> Signed-off-by: Jan Beulich >> >> --- >> This is a fix for Xen 4.5 to compile the hypervisor with GCC 4.9.1, used by >> Fedora & co. >> >> Jan: I kept your Signed-off-by for the commit message. > > I don't think you should have - nothing of my original fix got retained > afaict. IMO you should convert this to a Reported-by. I wasn't sure if Signed-off-by was required when copying the commit message. I will replace the Signed-off-by by Reported-by. Regards, -- Julien Grall