From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 for 4.5] arm32: fix build after 063188f4b3 Date: Mon, 13 Oct 2014 17:05:48 +0100 Message-ID: <543BF85C.4070109@linaro.org> References: <1413214141-370-1-git-send-email-julien.grall@linaro.org> <543C111B020000780003E67B@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xdi8D-00017S-7q for xen-devel@lists.xenproject.org; Mon, 13 Oct 2014 16:05:57 +0000 Received: by mail-wg0-f42.google.com with SMTP id z12so8963242wgg.25 for ; Mon, 13 Oct 2014 09:05:55 -0700 (PDT) In-Reply-To: <543C111B020000780003E67B@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Jan, On 10/13/2014 04:51 PM, Jan Beulich wrote: >>>> On 13.10.14 at 17:29, wrote: >> --- /dev/null >> +++ b/xen/arch/arm/arm32/smc.S >> @@ -0,0 +1,19 @@ >> +/* >> + * xen/arch/arm/arm32/smc.S >> + * >> + * Wrapper for Secure Monitors Calls >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +GLOBAL(do_smc) >> + smc #0 >> + mov pc, lr > > If you defined a little "ret" helper macro there wouldn't be a need > for separate files for 32- and 64-bit. Good point. I will give a look to this solution. Regards, -- Julien Grall