From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, hannes@stressinduktion.org
Subject: Re: [PATCH stable 3.2 3.4] ipv4: disable bh while doing route gc
Date: Mon, 13 Oct 2014 13:58:31 -0300 [thread overview]
Message-ID: <543C04B7.1040005@redhat.com> (raw)
In-Reply-To: <20141013.125225.1129718741415025861.davem@davemloft.net>
On 13-10-2014 13:52, David Miller wrote:
> From: Marcelo Ricardo Leitner <mleitner@redhat.com>
> Date: Mon, 13 Oct 2014 13:20:38 -0300
>
>> Further tests revealed that after moving the garbage collector to a work
>> queue and protecting it with a spinlock may leave the system prone to
>> soft lockups if bottom half gets very busy.
>>
>> It was reproced with a set of firewall rules that REJECTed packets. If
>> the NIC bottom half handler ends up running on the same CPU that is
>> running the garbage collector on a very large cache, the garbage
>> collector will not be able to do its job due to the amount of work
>> needed for handling the REJECTs and also won't reschedule.
>>
>> The fix is to disable bottom half during the garbage collecting, as it
>> already was in the first place (most calls to it came from softirqs).
>>
>> Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
>> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> Please add my:
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
> and submit this directly to -stable, thanks.
Will do. Thanks.
Marcelo
next prev parent reply other threads:[~2014-10-13 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 16:20 [PATCH stable 3.2 3.4] ipv4: disable bh while doing route gc Marcelo Ricardo Leitner
2014-10-13 16:52 ` David Miller
2014-10-13 16:58 ` Marcelo Ricardo Leitner [this message]
2014-10-13 17:51 ` [PATCH stable v3.2 v3.4] " David Miller
2014-10-20 3:09 ` Ben Hutchings
2014-10-20 4:23 ` David Miller
2014-10-20 12:23 ` Ben Hutchings
2014-10-20 15:39 ` David Miller
2014-10-21 19:08 ` Marcelo Ricardo Leitner
2014-10-21 19:32 ` Ben Hutchings
2014-10-21 19:51 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543C04B7.1040005@redhat.com \
--to=mleitner@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.