From mboxrd@z Thu Jan  1 00:00:00 1970
From: Emil Velikov <emil.l.velikov@gmail.com>
Subject: Re: [PATCH] drm/nouveau/disp: Use NULL for pointers
Date: Mon, 13 Oct 2014 20:16:57 +0100
Message-ID: <543C2529.2080708@gmail.com>
References: <1405944178-3500-1-git-send-email-thierry.reding@gmail.com>
 <20141013114749.GA16186@ulmo>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48])
 by gabe.freedesktop.org (Postfix) with ESMTP id 88AEB8913B
 for <dri-devel@lists.freedesktop.org>; Mon, 13 Oct 2014 12:17:36 -0700 (PDT)
Received: by mail-wg0-f48.google.com with SMTP id k14so9414418wgh.7
 for <dri-devel@lists.freedesktop.org>; Mon, 13 Oct 2014 12:17:35 -0700 (PDT)
In-Reply-To: <20141013114749.GA16186@ulmo>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Thierry Reding <thierry.reding@gmail.com>, Ben Skeggs <bskeggs@redhat.com>
Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 13/10/14 12:47, Thierry Reding wrote:
> On Mon, Jul 21, 2014 at 02:02:58PM +0200, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> The return type of exec_lookup() is struct nvkm_output *, so it should
>> return NULL rather than 0.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>> ---
>>  drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
>> index fa30d8196f35..ebf64e1d0a70 100644
>> --- a/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
>> +++ b/drivers/gpu/drm/nouveau/core/engine/disp/nvd0.c
>> @@ -939,7 +939,7 @@ exec_lookup(struct nv50_disp_priv *priv, int head, int or, u32 ctrl,
>>  		case 0x00000900: type = DCB_OUTPUT_DP; mask = 2; break;
>>  		default:
>>  			nv_error(priv, "unknown SOR mc 0x%08x\n", ctrl);
>> -			return 0x0000;
>> +			return NULL;
>>  		}
>>  	}
>>  
> 
> Ping?
> 
> Thierry
> 
I have an identical patch in a local branch, but with worse commit
message :) Fwiw the patch is

Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

-Emil