From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbaJMUdR (ORCPT ); Mon, 13 Oct 2014 16:33:17 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:32262 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752931AbaJMUdQ (ORCPT ); Mon, 13 Oct 2014 16:33:16 -0400 Message-ID: <543C36FF.8090608@fb.com> Date: Mon, 13 Oct 2014 14:33:03 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Dmitry Monakhov , CC: Subject: Re: [PATCH] block: update locking context for blk_free_devt References: <1413225357-18981-1-git-send-email-dmonakhov@openvz.org> <543C33B1.2010700@fb.com> <8738arra1p.fsf@openvz.org> In-Reply-To: <8738arra1p.fsf@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.57.29] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.28,0.0.0000 definitions=2014-10-13_03:2014-10-13,2014-10-13,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 spamscore=0 suspectscore=2 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1410130207 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-10-13 14:26, Dmitry Monakhov wrote: > Jens Axboe writes: > >> On 2014-10-13 12:35, Dmitry Monakhov wrote: >>> After 2da78092 this function will not longer sleepy >>> >>> Signed-off-by: Dmitry Monakhov >>> --- >>> block/genhd.c | 4 +--- >>> 1 files changed, 1 insertions(+), 3 deletions(-) >>> >>> diff --git a/block/genhd.c b/block/genhd.c >>> index 09da5e4..ae9aaa5 100644 >>> --- a/block/genhd.c >>> +++ b/block/genhd.c >>> @@ -441,12 +441,10 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt) >>> * Free @devt which was allocated using blk_alloc_devt(). >>> * >>> * CONTEXT: >>> - * Might sleep. >>> + * Don't care. >>> */ >>> void blk_free_devt(dev_t devt) >>> { >>> - might_sleep(); >>> - >>> if (devt == MKDEV(0, 0)) >>> return; >> >> What's this against? The might_sleep() was killed about a month ago by >> commit 46f341ffcfb5. The comment wasn't updated though, it should be. > Against 764f612c6c3c23 linux-block/for-next. > I've found this during development other blockdev related feature. > can you please point what is your development branch. Ah, I see. The devel branches are always for-3.x/core and for-3.x/drivers, so right now the current ones are for-3.18/core and so forth. That fix went into master, and I generally don't pull into the devel branches unless I really have to. This particular one should probably have gone in, since it spews a warning. Generally I expect people running them to use for-next, which really should be merged with master. I will just pull it in. for-next can and will be rebased sometimes though, only the real devel branches are more or less set in stone when it comes to history. So for development purposes, those should be used and not for-next. -- Jens Axboe